New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPAN PRC] A bunch of mostly cosmetic changes #51

Merged
merged 8 commits into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@JJ
Contributor

JJ commented Jan 3, 2017

Main one is probably adding .travis.yml for continuous integration. None touches the code itself. All address issues which I previously created.

JJ added some commits Jan 3, 2017

Eliminates empty README.
Goes to aspiers/mysqldiff#44 and eventually closes #44. First step CPAN pull request challenge PRC.
Added LICENSE
There are several versions of the Artistic License, this is the 1.0 clarified. Refers to aspiers/mysqldiff#45, and will close #45
Fixes `CONTRIBUTING.md` formatting
Part of the PRC, refers to aspiers/mysqldiff#46 and closes #46 when accepted.
Erased old installation instructions
And included new installation instructions. Refers to aspiers/mysqldiff#48, closes #48.
@estrabd

This comment has been minimized.

Show comment
Hide comment
@estrabd

estrabd Jan 3, 2017

Collaborator

@JJ thanks! I am happy to see that this module/util is getting some PRC love. Would you do me a favor and squash the travis ci commits? After that I see no reason to not accept this PR.

Collaborator

estrabd commented Jan 3, 2017

@JJ thanks! I am happy to see that this module/util is getting some PRC love. Would you do me a favor and squash the travis ci commits? After that I see no reason to not accept this PR.

@JJ

This comment has been minimized.

Show comment
Hide comment
@JJ

JJ Jan 3, 2017

Contributor
Contributor

JJ commented Jan 3, 2017

@JJ

This comment has been minimized.

Show comment
Hide comment
@JJ

JJ Jan 3, 2017

Contributor
Contributor

JJ commented Jan 3, 2017

@neilb

This comment has been minimized.

Show comment
Hide comment

neilb commented Jan 16, 2017

👍

@JaderDias

This comment has been minimized.

Show comment
Hide comment
@JaderDias

JaderDias Apr 2, 2017

@estrabd could you review this Pulll Request again?

@estrabd could you review this Pulll Request again?

@estrabd

This comment has been minimized.

Show comment
Hide comment
@estrabd

estrabd Jun 5, 2018

Collaborator

Thanks, sorry for the extreme delay @JaderDias and @neilb ! Merging.

Collaborator

estrabd commented Jun 5, 2018

Thanks, sorry for the extreme delay @JaderDias and @neilb ! Merging.

@estrabd estrabd merged commit 6804742 into aspiers:master Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment