Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Apple Sign-in #314

Closed
leastprivilege opened this issue Jun 4, 2019 · 16 comments
Closed

Support for Apple Sign-in #314

leastprivilege opened this issue Jun 4, 2019 · 16 comments

Comments

@leastprivilege
Copy link

@leastprivilege leastprivilege commented Jun 4, 2019

I think it's about time that this repo also supports Apple Sign-in.

Please implement ;)

IdentityServer/IdentityServer4#3312 (comment)

@martincostello
Copy link
Member

@martincostello martincostello commented Jun 4, 2019

I wondered how long until someone asked about this... 😄

I haven't read up on the implementation details yet - is it OAuth 2.0 based?

@kevinchalet
Copy link
Member

@kevinchalet kevinchalet commented Jun 4, 2019

Please implement ;)

Well, you know how it works 😄

I haven't read up on the implementation details yet - is it OAuth 2.0 based?

Yeah, it's an OpenID Connect code flow with a non-standard client authentication logic, inspired by OIDC's private_key_jwt method. Oh, and there's no discovery endpoint (but there's a JWKS doc' at https://appleid.apple.com/auth/keys)

@martincostello
Copy link
Member

@martincostello martincostello commented Jun 4, 2019

Fun - I might take a look at the weekend and see how long it takes my eyes to bleed 😄

@martincostello
Copy link
Member

@martincostello martincostello commented Jun 5, 2019

@leastprivilege Thanks!

@blowdart
Copy link

@blowdart blowdart commented Jun 6, 2019

Auth0 broke down how the client ID works

https://auth0.com/blog/what-is-sign-in-with-apple-a-new-identity-provider/

@martincostello
Copy link
Member

@martincostello martincostello commented Jun 6, 2019

Skeleton 💀 implementation begun in #318.

@dbevan-kabam
Copy link

@dbevan-kabam dbevan-kabam commented Aug 9, 2019

@martincostello, just trying this and I'm getting System.Exception: An error was encountered while handling the remote login. ---> System.Exception: The oauth state was missing or invalid.
I also get this on your sample app https://github.com/martincostello/SignInWithAppleSample.
Maybe something has changed their end or I'm doing something incorrectly?

@martincostello
Copy link
Member

@martincostello martincostello commented Aug 9, 2019

@dbevan-kabam I've seen some mention in others' blog posts about the scopes being set on the first request for a user causing issues (at least, I think it was the scopes), but I couldn't replicate it myself.

You could try clearing the scopes and seeing if that fixes it?

https://github.com/martincostello/SignInWithAppleSample/blob/20191322779c989c98ac1d0e50442526c52b2125/src/SignInWithApple/Apple/AppleAuthenticationOptions.cs#L31-L32

@martincostello
Copy link
Member

@martincostello martincostello commented Sep 23, 2019

@zicjin
Copy link

@zicjin zicjin commented Oct 7, 2019

Can we get a jwt simple?

@martincostello
Copy link
Member

@martincostello martincostello commented Oct 12, 2019

Publishing the 2.2.0 and 3.0.0 versions of this package may be delayed, as another user has uploaded a prerelease version of the package to NuGet.org so we won't have permission to publish additional versions without either a rename or them transferring ownership and/or granting co-ownership of the package.

I've reached out to the user via the "Contact owners" feature in NuGet.org.

You sent the following message via NuGet Gallery:
User martin_costello sends the following message to the owners of Package 'AspNet.Security.OAuth.Apple 2.1.1-preview'.

Hi,

Would you please consider transferring the package Id to the aspnet-contrib organisation/user (or making it a co-owner) please?

We're unable to publish the final 2.2 and 3.0 versions of this package as the package Id has been claimed by you.

Regards, Martin

/cc @PinpointTownes

@kevinchalet
Copy link
Member

@kevinchalet kevinchalet commented Oct 12, 2019

@martincostello
Copy link
Member

@martincostello martincostello commented Oct 14, 2019

Packages for Sign In with Apple are now available for ASP.NET Core 2.1+ and 3.0 in NuGet.org:

@suencien
Copy link

@suencien suencien commented Apr 18, 2020

Hi guys, does anyone have reference to ASP.NET Web Forms version with OpenId Connect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants