New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Meetup.com" provider #220

Open
wants to merge 18 commits into
base: dev
from

Conversation

3 participants
@dance2die
Copy link

dance2die commented Feb 24, 2018

Hi, I have added a provider for Meetup.com.

Would you review the content and see if it's mergeable?
Please let me know should the merge does not conform to a guideline or a standard.

Test Steps

  1. Add .AddMeetup in Startup.cs
.AddMeetup(options =>
{
    options.ClientId = "CLIENT ID";
    options.ClientSecret = "CLIENT SECRET";
    options.Scope.Add("basic");
});

The list of Scope values can be found here.

  1. Create a Meetup OAuth consumer from here to get a ClientId (shown as Key) and ClientSecret (shown as Secret)
    2.1 and set the Redirect URL to "https://localhost:44318/"
    firefox_2018-02-23_20-42-11

Once you've added the Meetup provider, the test site will display "Connect using Meetup" as shown below
chrome_2018-02-23_20-35-51

  1. Login to Meetup.com

  2. Redirected page shows claims processed
    chrome_2018-02-23_20-38-51

@dance2die

This comment has been minimized.

Copy link

dance2die commented Feb 24, 2018

@PinpointTownes Hi Kevin,

Would you be able to guide me on what I am doing wrong and how I can fix the issue?
(I've left a comment on the build failure on Gitter, just in case)

Thank you.

@kinosang

This comment has been minimized.

Copy link
Contributor

kinosang commented Feb 24, 2018

CI failed because it can't download KoreBuild from GitHub. No idea why it happened.

ClaimActions.MapJsonKey("urn:meetup:localized_country_name", "localized_country_name");
ClaimActions.MapJsonKey("urn:meetup:state", "state");

// Map user's photo information returned as a nested object

This comment has been minimized.

@kinosang

kinosang Feb 24, 2018

Contributor

keep the indent of 12 spaces.

This comment has been minimized.

@dance2die

dance2die Feb 24, 2018

I am sorry about that.
My Visual Studio has tabs as a space by default. I will update the indentations.

ClaimActions.MapJsonKey(ClaimTypes.Email, "email");

// Map custom claims
ClaimActions.MapJsonKey("urn:meetup:name", "name");

This comment has been minimized.

@kinosang

kinosang Feb 24, 2018

Contributor

See #216, it introduces ClaimTypes constants for the claims.

This comment has been minimized.

@dance2die

dance2die Feb 24, 2018

OK, let me refer to the #216

@dance2die

This comment has been minimized.

Copy link

dance2die commented Feb 24, 2018

@kinosang
AppVeyor is still failing while Travis is passing.

According to GitHub issue on AspNet KoreBuild, zip version is not supported any more

@PinpointTownes

This comment has been minimized.

Copy link
Member

PinpointTownes commented Feb 24, 2018

According to GitHub issue on AspNet KoreBuild, zip version is not supported any more

We'll probably move to the new version at some point, but the error you're seeing on AppVeyor doesn't have anything to do with that: it's caused by the fact the GitHub.com folks removed support for TLS 1.0 and 1.1 2 days ago. The AppVeyor team is working on a global fix to force .NET apps to use TLS 1.2 in all their CI images.

In the meantime, let's just ignore the AppVeyor errors.

@dance2die

This comment has been minimized.

Copy link

dance2die commented Feb 24, 2018

Thank you for looking into the AppVeyor issue @PinpointTownes.

@dance2die

This comment has been minimized.

Copy link

dance2die commented Feb 28, 2018

I've rebased according to an advice in #224.
Would you review to see if the rebase is done properly? (My first time doing a rebase).
Thank you.

@PinpointTownes PinpointTownes force-pushed the aspnet-contrib:dev branch from f5a5364 to 84d5005 Mar 7, 2018

@PinpointTownes PinpointTownes added this to the 2.1.0 milestone Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment