Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch "public" with "read" since that is the base scope for Strava. #443

Merged
merged 1 commit into from Jul 3, 2020

Conversation

bryantlikes
Copy link
Contributor

Based on https://developers.strava.com/docs/authentication/ there is no "public" scope for Strava.

Uses "read" instead of "public" as the default scope.

@martincostello
Copy link
Member

Thanks @bryantlikes - I assume this came out of you testing it out with a real integration and this fixed it?

@bryantlikes
Copy link
Contributor Author

Thanks @bryantlikes - I assume this came out of you testing it out with a real integration and this fixed it?

Yes, if you pass "public" you will get an error back from Strava:

{"message":"Bad Request","errors":[{"resource":"Authorize","field":"scope","code":"invalid"}]}

@martincostello martincostello merged commit 20a5b0a into aspnet-contrib:dev Jul 3, 2020
@martincostello martincostello added this to the 3.1.2 milestone Jul 3, 2020
@martincostello
Copy link
Member

Thanks @bryantlikes! 🥳

@martincostello
Copy link
Member

Version 3.1.2 of the Strava provider which contains this fix is now available from NuGet.org: https://www.nuget.org/packages/AspNet.Security.OAuth.Strava/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants