Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn Analyzers and ASP.NET 5 Projects in Visual Studio 2015 Preview #196

Closed
tugberkugurlu opened this issue Nov 15, 2014 · 5 comments
Closed

Comments

@tugberkugurlu
Copy link
Contributor

@tugberkugurlu tugberkugurlu commented Nov 15, 2014

When you install Microsoft.CodeAnalysis.CSharp.FxCopAnalyzers into a regular console project, it runs the following install.ps1 script to add the analyzer references:

param($installPath, $toolsPath, $package, $project)

$analyzersPath = join-path $toolsPath "analyzers"

foreach ($analyzerFilePath in Get-ChildItem -Recurse $analyzersPath)
{
    $project.Object.AnalyzerReferences.Add($analyzerFilePath.FullName)
}

It looks like this:

image

However, this doesn't work with ASP.NET 5 projects.

Also, I can assume that this is also integrated into the build process through custom msbuild scripts. That's why I'm not sure how this would look like in ASP.NET 5 projects as MSBuild is not the only build tool.

@davidfowl

This comment has been minimized.

Copy link
Member

@davidfowl davidfowl commented Nov 15, 2014

Doesn't work yet. We're stilling plumbing this through the system.

@tugberkugurlu

This comment has been minimized.

Copy link
Contributor Author

@tugberkugurlu tugberkugurlu commented Nov 15, 2014

got it. How would the package look like inside project.json? new type, maybe?

"Microsoft.CodeAnalysis.CSharp.FxCopAnalyzers": { 
    "version": "1.0.0-beta1-20141031-01", 
    "type": "analyzer" 
}
@Kieranties

This comment has been minimized.

Copy link

@Kieranties Kieranties commented Jul 6, 2015

@davidfowl with this being closed, does that mean a fix is incoming?

@davidfowl

This comment has been minimized.

Copy link
Member

@davidfowl davidfowl commented Jul 6, 2015

There's already a bug tracking the work in the dnx

@Kieranties

This comment has been minimized.

Copy link

@Kieranties Kieranties commented Jul 6, 2015

ryanbrandenburg pushed a commit that referenced this issue Nov 19, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 19, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 21, 2018
dougbu pushed a commit to dotnet-maestro-bot/AspNetCore that referenced this issue Sep 11, 2019
…nnecessary exclusions in NuGetPackageVerifier.json
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.