New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IDistributedCache #2603

Closed
aspnet-hello opened this Issue Jan 2, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@aspnet-hello
Copy link

aspnet-hello commented Jan 2, 2018

From @mgroves on Wednesday, September 6, 2017 6:26:09 AM

It doesn't appear that ResponseCache works with IDistributedCache (see this issue over at Couchbase.Extensions. Please correct me if I'm wrong.

Will you be adding support for IDistributedCache in the future?

Copied from original issue: aspnet/ResponseCaching#137

@aspnet-hello

This comment has been minimized.

Copy link

aspnet-hello commented Jan 2, 2018

From @Jetski5822 on Monday, October 23, 2017 1:52:46 AM

+1

Or at least open the middleware up to allow us to inject a distributes cache implementation in to it. Is there a reason why https://github.com/aspnet/ResponseCaching/blob/dev/src/Microsoft.AspNetCore.ResponseCaching/ResponseCachingMiddleware.cs#L40 is not injected in? Thus allowing us to swap the implementation?

@aspnet-hello

This comment has been minimized.

Copy link

aspnet-hello commented Jan 2, 2018

From @hampos on Wednesday, November 22, 2017 3:43:59 AM

+1

The constructor should be opened to allow injecting other IResponseCache implementations.
@JunTaoLuo Any plans on doing just that?

@aspnet-hello

This comment has been minimized.

Copy link

aspnet-hello commented Jan 2, 2018

From @JunTaoLuo on Wednesday, November 22, 2017 11:28:48 AM

No current plans for it yet, it will need to be triaged for a future release. cc @muratg

@aspnet-hello

This comment has been minimized.

Copy link

aspnet-hello commented Jan 2, 2018

From @theofanis on Thursday, November 23, 2017 12:42:23 AM

+1

@JunTaoLuo Any valid reason why this doesn't depend on an injected IResponseCache implementation and go with the new MemoryResponseCache when calling the internal constructor?

If you were set to the MemoryResponseCache usage, you could make this optional and initialize to MemoryResponseCache when omitted, a good documentation would then steer developers on how to use this correctly.

When you say future release, does this mean wait 6 months? The answer is vital because it may make more sense for us to just fork this and go with our own version until you guys push it.

@aspnet-hello

This comment has been minimized.

Copy link

aspnet-hello commented Jan 2, 2018

From @muratg on Thursday, November 23, 2017 11:54:23 AM

@DamianEdwards @glennc

@muratg

This comment has been minimized.

Copy link
Member

muratg commented Jan 10, 2019

@DamianEdwards @glennc I'm closing this. Feel free to reopen if you'd like to get this anytime soon.

@muratg muratg closed this Jan 10, 2019

@RehanSaeed

This comment has been minimized.

Copy link

RehanSaeed commented Jan 11, 2019

Does this mean that we are definately not getting this for 3.0 and maybe even beyond?

@muratg

This comment has been minimized.

Copy link
Member

muratg commented Jan 11, 2019

@RehanSaeed Not for 3.0. In case we end up budgeting for this later, this may end up coming back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment