New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS: ASP.NET Core Module blocks install when Shared Configuration is used - 2.2.0-preview3 to RTM regression #4451

Open
NickCraver opened this Issue Dec 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@NickCraver

NickCraver commented Dec 6, 2018

When we tried to upgrade our 2.2.0-preview3 ASP.NET Core IIS hosting module to 2.2.0 via Puppet, we get an error:

image

It seems this is a regression from the preview 3 release where it was allowed. This has changed our Puppet deploy from working to inoperable. Disabling and re-enabling Shared Configiuration is non-trivial and a ton more to automate for deploy of this module. My understanding from Twitter is that some configurations broke with this (ours was fine) and so as a result none are allowed.

I'd imagine anyone using Chocolatey to install has the same issue with the scenario, so an extra arg to bypass the check shouldn't be the first solution here. Can we please only check for the error and present this message only if it's a problem?

We had several projects ready to go live on 2.2 and others that are on preview3, so suffice to say this is quite the killer to rollout plans and a real enthusiasm curber - it's currently blocking our rollout of 2.2 at Stack Overflow. We need 2.2 RTM for .exe naming, which affects service deploys and such...since that transition is painful from preview3, we've delayed releases until RTM lands (and now...indefinitely). A fix to this soon would be much appreciated.

To Reproduce

Steps to reproduce the behavior:

  1. Enable shared configuration
  2. Install 2.2.0-preview 3 hosting module
  3. Attempt to install 2.2.0 RTM hosting module

Expected behavior

This should be allowed as it was in 2.2.0-preview3.

cc @DamianEdwards @shirhatti

@NickCraver NickCraver changed the title from IIS: ASP.NET Core Module blocks when Shared Configuration is used - 2.2.0-preview3 to RTM regression to IIS: ASP.NET Core Module blocks install when Shared Configuration is used - 2.2.0-preview3 to RTM regression Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment