New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class IEndpointFeature and IRoutingFeature in Kestrel #6596

Open
davidfowl opened this Issue Jan 11, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@davidfowl
Copy link
Member

davidfowl commented Jan 11, 2019

Today Kestrel has a fast path to avoid dictionary lookups by exposing features as fields on the it's IFeatureCollection implementation. We need to add the very commonly used IEndpointFeature and IRoutingFeature to this set this set:

cc @rynowak @JamesNK

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 11, 2019

Have you checked every feature assigned durring a normal mvc request?

@davidfowl

This comment has been minimized.

Copy link
Member

davidfowl commented Jan 11, 2019

This isn't for MVC, this is for routing. I haven't looked at all of the features used by default in MVC though.

@rynowak

This comment has been minimized.

Copy link
Member

rynowak commented Jan 11, 2019

The additional features MVC commonly uses are:

  • Services
  • Routing
  • Endpoint Routing
  • Form
  • Antiforgery
@muratg

This comment has been minimized.

Copy link
Member

muratg commented Jan 11, 2019

@davidfowl Moved this out to preview3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment