Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValuesController in the API template doesn't use modern features or idioms #8534

Open
DamianEdwards opened this Issue Mar 14, 2019 · 1 comment

Comments

Projects
3 participants
@DamianEdwards
Copy link
Member

DamianEdwards commented Mar 14, 2019

ValuesController doesn't have the API Controller conventions configured or the analyzers, and the action methods have parameters that require attributes. We should consider changing it to an example that is more idiomatic.

@glennc

@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview4 milestone Mar 21, 2019

@mkArtakMSFT mkArtakMSFT added this to To do in Templates via automation Mar 21, 2019

@mkArtakMSFT

This comment has been minimized.

Copy link
Member

mkArtakMSFT commented Mar 21, 2019

@glennc, waiting for you to define how this should look. Should we still have ValuesController as this was something we've talked about and never locked down on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.