Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log directory #10301

Merged
merged 3 commits into from May 17, 2019
Merged

Update log directory #10301

merged 3 commits into from May 17, 2019

Conversation

JunTaoLuo
Copy link
Contributor

Addresses #7316.

The issue is that the log directory for functional test logs is by default $(RepoRoot)artifacts\log\ but our ci configuration publishes artifacts\logs\ instead.

There's a bunch of different ways to fix this:

  1. Change the directory in ci.yml
  2. Change the default functional test log from artifacts\log to artifacts\logs
  3. Set an environment variable to override the default log output dir.

I opted for 1. but can easily go with another approach, especially if artifacts/logs/ is a better conventionl.

@JunTaoLuo JunTaoLuo requested a review from a team as a code owner May 16, 2019 18:55
@natemcmaster
Copy link
Contributor

+1, this contributes to #7280 (convert to arcade) as artifacts/log/ is the Arcade convention.

Can we take this a step further and update everything to use this folder? Add this to build/repo.props to override the KoreBuild default:

<LogOutputDir>$(ArtifactsDir)log\</LogOutputDir>

@Eilon Eilon added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-signalr Includes: SignalR clients and servers labels May 16, 2019
@JunTaoLuo JunTaoLuo removed the area-signalr Includes: SignalR clients and servers label May 16, 2019
@JunTaoLuo JunTaoLuo merged commit 818dc3b into master May 17, 2019
@ghost ghost deleted the johluo/change-log-dir branch May 17, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants