Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy race for IIS projects #11394

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@jkotalik
Copy link
Member

commented Jun 19, 2019

There is a race when native dlls are being copied to build samples/test projects due to the file being locked. This can happen when the native dlls are being written to on build finishing. I believe this will fix the race.

@jkotalik jkotalik requested review from anurse, halter73 and Tratcher as code owners Jun 19, 2019

@anurse anurse added the area-servers label Jun 19, 2019

@anurse anurse added this to the 3.0.0-preview7 milestone Jun 19, 2019

@jkotalik jkotalik requested a review from JunTaoLuo Jun 19, 2019

@JunTaoLuo
Copy link
Contributor

left a comment

We'll give it a shot! Thanks!

@jkotalik jkotalik merged commit 0b5d4ba into master Jun 20, 2019

16 checks passed

AspNetCore-ci Build #20190619.32 had test failures
Details
AspNetCore-ci (Build: Linux ARM) Build: Linux ARM succeeded
Details
AspNetCore-ci (Build: Linux ARM64) Build: Linux ARM64 succeeded
Details
AspNetCore-ci (Build: Linux Musl ARM64) Build: Linux Musl ARM64 succeeded
Details
AspNetCore-ci (Build: Linux Musl x64) Build: Linux Musl x64 succeeded
Details
AspNetCore-ci (Build: Linux x64) Build: Linux x64 succeeded
Details
AspNetCore-ci (Build: Windows ARM) Build: Windows ARM succeeded
Details
AspNetCore-ci (Build: Windows x64/x86) Build: Windows x64/x86 succeeded
Details
AspNetCore-ci (Build: macOS) Build: macOS succeeded
Details
AspNetCore-ci (Code check) Code check succeeded
Details
AspNetCore-ci (Test: Templates - Windows Server 2016 x64) Test: Templates - Windows Server 2016 x64 succeeded
Details
AspNetCore-ci (Test: Ubuntu 16.04 x64) Test: Ubuntu 16.04 x64 succeeded with issues
Details
AspNetCore-ci (Test: Windows Server 2016 x64) Test: Windows Server 2016 x64 succeeded with issues
Details
AspNetCore-ci (Test: macOS 10.13) Test: macOS 10.13 succeeded with issues
Details
AspNetCore-helix-test Build #20190619.24 succeeded
Details
license/cla All CLA requirements met.

@aspnet-github-bot aspnet-github-bot bot deleted the jkotali/fixIisCopy branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.