New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to Mono WebAssembly changes for 3.1 preview3 #16631
React to Mono WebAssembly changes for 3.1 preview3 #16631
Conversation
/// Gets or sets the default value of the 'credentials' option on outbound HTTP requests. | ||
/// Defaults to <see cref="FetchCredentialsOption.SameOrigin"/>. | ||
/// </summary> | ||
public static FetchCredentialsOption DefaultCredentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not going to survive API review eventually, but it's the closest thing to what we already have. I don't want to design a new thing just as part of reacting to an external change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest change in this PR is the removal of our own HttpClient handler in favor of one provided by Mono, is that the case?
I don't remember stuff about the MSBuild piece, but that might change in the future, so I think this is good.
Thanks for taking care of this!
Yes. Mono has removed the ability to set a custom default HttpMessageHandler, which we were doing before. The default is now always the one in Mono's The main complication is that we don't expose any reference to |
So this fixes some of the HTTP streaming issues like #5586, #13329 ? |
FYI @anurse \ @BrennanConroy |
Are you saying that |
I had thought that would be the case, but we just spoke with the Mono team today and apparently it is not. There is currently still a separate wasm-specific HTTP handler; the change is that it's provided by Mono now and not by Blazor. We have asked for this design to be reconsidered because we do want things like @BrennanConroy You might also be interested to know that we're not far off having proper |
@Pilchie Need approval for preview 3 |
Approved for 3.1.0-Preview3. |
f7a2a34
to
0860243
Compare
0860243
to
0272d4d
Compare
The changes here have been merged as part of #16685 |
This is necessary when we receive the changes in dotnet/blazor#1923
Until then, this will fail on build.