Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test logs from SDL validation #16931

Closed
wants to merge 2 commits into from

Conversation

@wtgodbe
Copy link
Contributor

wtgodbe commented Nov 8, 2019

Resolves (part of) #16835

I'm trying to exclude all files under "artifacts/Linux_Test_Results/" and friends.

I have an internal build running with this change: https://dnceng.visualstudio.com/internal/_build/results?buildId=420854

@sunandabalu PTAL

@wtgodbe wtgodbe requested a review from aspnet/build Nov 8, 2019
@sunandabalu

This comment has been minimized.

Copy link

sunandabalu commented Nov 8, 2019

The change itself looks fine to me, waiting to see the results of the test build.

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 8, 2019

This decreased SDL time from 50 to 17 minutes 🍾 ❗️

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 8, 2019

@Pilchie @JunTaoLuo @dougbu now I'm thinking I should just backport this to #16911 instead of disabling in 3.1 - any objections?

@sunandabalu

This comment has been minimized.

Copy link

sunandabalu commented Nov 8, 2019

Policheck is failing with invalid path to /UEPATH . You probably need to give it full path for it to get the file.

Invalid value for /UEPATH: eng/PoliCheckExclusions.xml

https://dnceng.visualstudio.com/internal/_build/results?buildId=420854&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9&t=f511b583-5060-5810-7549-865816347c8e&l=287

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 8, 2019

Policheck is failing with invalid path to /UEPATH

Well never mind then. I'll try passing the full path

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 8, 2019

@dougbu
dougbu approved these changes Nov 9, 2019
Copy link
Member

dougbu left a comment

Looks good but isn't SDK enabled in 'release/3.1' as well?

eng/PoliCheckExclusions.xml Show resolved Hide resolved
@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 9, 2019

Looks good but isn't SDK enabled in 'release/3.1' as well?

It is, but for the sake of minimizing risk in GA I think disabling it there is best. This PR already had 2 iterations. We probably won't trigger anything new in 3.1 with the GA builds, and disabling SDL will speed up the internal builds by up to 50 minutes.

@sunandabalu

This comment has been minimized.

Copy link

sunandabalu commented Nov 12, 2019

New build: https://dnceng.visualstudio.com/internal/_build/results?buildId=421143

I see Policheck issues only for files under src, @wtgodbe can you confirm the right folders were excluded?

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 14, 2019

Closing in favor of #17107

@wtgodbe wtgodbe closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.