Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing OSX tests in 3.1 #16932

Closed
wants to merge 1 commit into from

Conversation

@wtgodbe
Copy link
Contributor

wtgodbe commented Nov 8, 2019

Disable failing tests from #16912 while we work on a fix. Merge this one first for GA

@wtgodbe wtgodbe added the tell-mode label Nov 8, 2019
@wtgodbe wtgodbe added this to the 3.1.0 milestone Nov 8, 2019
@anurse
anurse approved these changes Nov 8, 2019
@BrennanConroy

This comment has been minimized.

Copy link
Member

BrennanConroy commented Nov 8, 2019

FYI, we probably have a fix. I'll make a PR to 3.0 for it and slowly port forward.

@dougbu

This comment has been minimized.

Copy link
Member

dougbu commented Nov 9, 2019

Why not mark the tests as flaky on macOS and Helix instead of skipping them completely? And, didn't @jkotalik do the Skip thing with the same tests in #16812?

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 9, 2019

Why not mark the tests as flaky on macOS and Helix instead of skipping them completely? And, didn't @jkotalik do the Skip thing with the same tests in #16812?

Because they're not flaky, they fail every time. @jkotalik did this same change but against master, I'm just backporting the part that disables them.

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 9, 2019

See dotnet/core-setup#8775 (comment) for more discussion

@BrennanConroy

This comment has been minimized.

Copy link
Member

BrennanConroy commented Nov 10, 2019

Alternative PR here, which fixes the tests and doesn't skip them.

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 10, 2019

Thanks @BrennanConroy! Closing this.

@wtgodbe wtgodbe closed this Nov 10, 2019
@wtgodbe wtgodbe deleted the DisableFlakesters branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.