Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we resolve dotnet in tests #16934

Merged
merged 3 commits into from Nov 10, 2019

Conversation

@BrennanConroy
Copy link
Member

BrennanConroy commented Nov 8, 2019

馃 hopefully this works

@BrennanConroy BrennanConroy requested a review from JunTaoLuo Nov 8, 2019
ugh
@JunTaoLuo

This comment has been minimized.

Copy link
Contributor

JunTaoLuo commented Nov 10, 2019

Note that we are currently not merging 3.0 into 3.1 so in the mean time we might want to cherry-pick this fix into 3.1 then merge to master.

@JunTaoLuo JunTaoLuo merged commit 2b2153a into release/3.0 Nov 10, 2019
17 of 19 checks passed
17 of 19 checks passed
AspNetCore-helix-test Build #20191108.15 had test failures
Details
AspNetCore-helix-test (Tests: Helix x64) Tests: Helix x64 failed
Details
AspNetCore-ci Build #20191108.15 had test failures
Details
AspNetCore-ci (Build Build: Linux ARM) Build Build: Linux ARM succeeded
Details
AspNetCore-ci (Build Build: Linux ARM64) Build Build: Linux ARM64 succeeded
Details
AspNetCore-ci (Build Build: Linux Musl ARM64) Build Build: Linux Musl ARM64 succeeded
Details
AspNetCore-ci (Build Build: Linux Musl x64) Build Build: Linux Musl x64 succeeded
Details
AspNetCore-ci (Build Build: Linux x64) Build Build: Linux x64 succeeded
Details
AspNetCore-ci (Build Build: Windows ARM) Build Build: Windows ARM succeeded
Details
AspNetCore-ci (Build Build: Windows x64/x86) Build Build: Windows x64/x86 succeeded
Details
AspNetCore-ci (Build Build: macOS) Build Build: macOS succeeded
Details
AspNetCore-ci (Build Code check) Build Code check succeeded
Details
AspNetCore-ci (Build Test: Linux Source Build) Build Test: Linux Source Build succeeded
Details
AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64) Build Test: Templates - Windows Server 2016 x64 succeeded
Details
AspNetCore-ci (Build Test: Ubuntu 16.04 x64) Build Test: Ubuntu 16.04 x64 succeeded
Details
AspNetCore-ci (Build Test: Windows Server 2016 x64) Build Test: Windows Server 2016 x64 succeeded
Details
AspNetCore-ci (Build Test: macOS 10.13) Build Test: macOS 10.13 succeeded
Details
AspNetCore-helix-test (Tests: Helix ARM64) Tests: Helix ARM64 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@JunTaoLuo JunTaoLuo deleted the brecon/osxWatch branch Nov 10, 2019
BrennanConroy added a commit that referenced this pull request Nov 10, 2019
wtgodbe added a commit that referenced this pull request Nov 11, 2019
Change how we resolve dotnet in tests (#16934)
@anurse anurse added this to the 3.0.1 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.