Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fewer things in blazor-wasm #17533

Merged
merged 1 commit into from Dec 3, 2019
Merged

Build fewer things in blazor-wasm #17533

merged 1 commit into from Dec 3, 2019

Conversation

@pranavkm
Copy link
Member

pranavkm commented Dec 2, 2019

No description provided.

@pranavkm pranavkm force-pushed the prkrishn/fewer-build branch 2 times, most recently from 5e6e380 to 8e14ad0 Dec 2, 2019
@pranavkm pranavkm force-pushed the prkrishn/fewer-build branch from 8e14ad0 to c7f28b0 Dec 2, 2019
@Pilchie Pilchie added the area-blazor label Dec 3, 2019
@pranavkm pranavkm marked this pull request as ready for review Dec 3, 2019
@pranavkm pranavkm requested review from ryanbrandenburg and aspnet/build as code owners Dec 3, 2019
@@ -1,339 +0,0 @@
// Copyright (c) .NET Foundation. All rights reserved.

This comment has been minimized.

Copy link
@ryanbrandenburg

ryanbrandenburg Dec 3, 2019

Member

Please leave these infrastructure pieces so that I can do #5485.

This comment has been minimized.

Copy link
@pranavkm

pranavkm Dec 3, 2019

Author Member

That should get resolved as part of #17410, Is there something specifically in that issue that requires these types?

This comment has been minimized.

Copy link
@pranavkm

pranavkm Dec 3, 2019

Author Member

Spoke offline, this looks ok

@pranavkm pranavkm merged commit 76ae0a2 into blazor-wasm Dec 3, 2019
7 of 8 checks passed
7 of 8 checks passed
AspNetCore-helix-test #20191202.21 failed
Details
AspNetCore-ci #20191202.25 succeeded
Details
AspNetCore-ci (Build Build: Windows x64/x86) Build Build: Windows x64/x86 succeeded
Details
AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64) Build Test: Templates - Windows Server 2016 x64 succeeded
Details
AspNetCore-ci (Build Test: Ubuntu 16.04 x64) Build Test: Ubuntu 16.04 x64 succeeded
Details
AspNetCore-ci (Build Test: Windows Server 2016 x64) Build Test: Windows Server 2016 x64 succeeded
Details
AspNetCore-ci (Build Test: macOS 10.13) Build Test: macOS 10.13 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.