New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo links for SignalR TS client in package.json after move #4425

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@christianliebel

christianliebel commented Dec 5, 2018

The SignalR TS client sources were moved to aspnet/AspNetCore, however this change hasn’t been reflected in package.json that is used for showing the readme and repository links on npmjs.com.

@natemcmaster

Looks good to me. We will also want to backport this to release/2.1 and 2.2 branches.

@BrennanConroy

This comment has been minimized.

Contributor

BrennanConroy commented Dec 5, 2018

I would hold off on this for a bit. We're discussing some things around this.

Show resolved Hide resolved src/SignalR/clients/ts/signalr/package.json Outdated
@mikaelm12

Much better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment