New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Auth UserInfo endpoint #6338

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
7 participants
@Tratcher
Copy link
Member

Tratcher commented Jan 3, 2019

#6069 for 2.1. The same change can be used for 2.2 and 3.0.

Description

Google is shutting down Google+ APIs that we were using for authentication. We need to move to a new API ASAP.

Customer Impact

Without this change web applications will no longer be able to log users in with Google accounts starting as soon as Jan 28th.

Regression?

Yes, by Google.

Risk

Moderate, the new APIs use a different data format and users may get subtly different results.

@Tratcher Tratcher self-assigned this Jan 3, 2019

@Tratcher Tratcher requested a review from HaoK Jan 3, 2019

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 3, 2019

@natemcmaster I assume the branches aren't open yet for Feb?

@natemcmaster

This comment has been minimized.

Copy link
Member

natemcmaster commented Jan 3, 2019

@Eilon since @muratg is oof, are you going to rep for this in shiproom?

@natemcmaster natemcmaster added this to the 2.1.x milestone Jan 3, 2019

@Eilon

This comment has been minimized.

Copy link
Member

Eilon commented Jan 3, 2019

Yes I will.

@HaoK

HaoK approved these changes Jan 3, 2019

@Eilon

Eilon approved these changes Jan 3, 2019

@natemcmaster

This comment has been minimized.

Copy link
Member

natemcmaster commented Jan 3, 2019

Please wait until the release/2.1 branch has been updated to build for 2.1.8. I'll add my approval when that is done. cref aspnet/AspNetCore-Internal#1610

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 3, 2019

Offline notes: Add a quirk to revert to the prior behavior.

@Eilon
Copy link
Member

Eilon left a comment

Un-signing off

@Tratcher Tratcher force-pushed the tratcher/2.1/google branch from f7b5afd to b86f4df Jan 3, 2019

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 3, 2019

Updated with the quirks switch AppContext.SetSwitch("Switch.Microsoft.AspNetCore.Authentication.Google.UsePlus", true);

@Eilon

Eilon approved these changes Jan 3, 2019

Copy link
Member

Eilon left a comment

I re-approve this.

@gilm0079 gilm0079 referenced this pull request Jan 8, 2019

Closed

Google+ Platform #2931

@muratg
Copy link
Member

muratg left a comment

Note for the shiproom: 2.2.x change will be identical to this, and it'll be a merge-PR.

@natemcmaster

This comment has been minimized.

Copy link
Member

natemcmaster commented Jan 8, 2019

Please wait until aspnet/AspNetCore-Internal#1610 is resolved before merging.

@natemcmaster natemcmaster modified the milestones: 2.1.x, 2.1.8 Jan 8, 2019

@jamshedd

This comment has been minimized.

Copy link
Member

jamshedd commented Jan 8, 2019

Approved for 2.1.8

@mikaelm12

This comment has been minimized.

Copy link
Contributor

mikaelm12 commented Jan 11, 2019

You'll also need to update https://github.com/aspnet/AspNetCore/blob/release/2.1/eng/PatchConfig.props with the packages that you are patching here.

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 11, 2019

@mikaelm12 do you want to bump the version and clear out the old packages from the list first?

@mikaelm12

This comment has been minimized.

Copy link
Contributor

mikaelm12 commented Jan 11, 2019

do you want to bump the version and clear out the old packages from the list first?

Sure

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 12, 2019

Updated, but needs to rebase.

@Tratcher Tratcher force-pushed the tratcher/2.1/google branch from 6f444a2 to 3761850 Jan 14, 2019

@Tratcher

This comment has been minimized.

Copy link
Member

Tratcher commented Jan 14, 2019

@mikaelm12 ready when you are.

@mikaelm12

This comment has been minimized.

Copy link
Contributor

mikaelm12 commented Jan 14, 2019

Great. The 2.1.8 branch will be ready today.

@Tratcher Tratcher merged commit 87af0c3 into release/2.1 Jan 14, 2019

1 check passed

license/cla All CLA requirements met.
Details

@Tratcher Tratcher deleted the tratcher/2.1/google branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment