New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging MvcPrecomp Reference to 2.2 #6590

Merged
merged 4 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jan 11, 2019

MvcPrecompilation part of #6569.

JunTaoLuo and others added some commits Jan 10, 2019

Convert MvcPrecomp to Reference (#6472)
* Convert MvcPrecomp to use Reference and move to MVC
Don't restore npmproj files in parallel (#6560)
NPM does not handle this well, so only run one NPM command at a time
@JunTaoLuo

This comment has been minimized.

Copy link
Contributor

JunTaoLuo commented Jan 11, 2019

@pranavkm @mkArtakMSFT It seems like the MvcPrecompilation functional tests are failing in 2.2 even before my changes. These need to be rewritten so I've disable them for now to get the reference and directory structure changes in. I'll file a follow up issue to fix the tests. Is that ok?

@natemcmaster
Copy link
Member

natemcmaster left a comment

One fix needed in the baseline file, but otherwise looks great. :shipit:

Show resolved Hide resolved eng/Baseline.xml Outdated

@JunTaoLuo JunTaoLuo force-pushed the johluo/merge-fix branch from a34130f to e46792c Jan 11, 2019

@JunTaoLuo

This comment has been minimized.

Copy link
Contributor

JunTaoLuo commented Jan 11, 2019

Blocked on #4067.

@JunTaoLuo JunTaoLuo force-pushed the johluo/merge-fix branch from e46792c to 520b36a Jan 14, 2019

@JunTaoLuo JunTaoLuo force-pushed the johluo/merge-fix branch from 520b36a to c2aa295 Jan 14, 2019

@JunTaoLuo JunTaoLuo merged commit c2aa295 into release/2.2 Jan 14, 2019

1 check passed

license/cla All CLA requirements met.
Details

@JunTaoLuo JunTaoLuo deleted the johluo/merge-fix branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment