Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Worker template #7401

Merged
merged 11 commits into from Feb 11, 2019

Conversation

@Tratcher
Copy link
Member

commented Feb 8, 2019

This is a first pass at #6817. @glennc I copied in a lot of your prototype, perhaps more than we're ready for this time around. The basic empty version works. Do we need to sort out the helm, webjobs, and docker stuff for preview3?

@Tratcher Tratcher added this to the 3.0.0-preview3 milestone Feb 8, 2019

@Tratcher Tratcher self-assigned this Feb 8, 2019

@Tratcher Tratcher requested review from glennc and natemcmaster Feb 8, 2019

@Tratcher

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

WebJobs does seem to be working locally.

@natemcmaster

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Build infrastructure looks fine. I don't have any other feedback on this. Don't have enough context on this PR to sign off or request changes.

cc @ryanbrandenburg, our project templating expert

@rynowak

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@Tratcher

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Hmm, VS doesn't pick up locally built and installed versions of the templates. Is that supposed to work?

@Tratcher Tratcher requested a review from ryanbrandenburg Feb 8, 2019

@rynowak

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Is that supposed to work?

I don't think so. I think it only honours the SDK.

@davidfowl

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Remove webjobs, helm and docker. Let get the skeleton in then decide how we do the cross cutting concerns.

@Eilon Eilon added the area-hosting label Feb 10, 2019

@glennc
Copy link
Member

left a comment

Remove all the options for now, we'll go through and add them back 1 by 1 thinking about each one as we do. Need to consider partners for all of them, mostly all the VS experiences around HELM and Docker still working.

Tratcher added some commits Feb 11, 2019

@Tratcher Tratcher changed the title [WIP] Background Worker template Background Worker template Feb 11, 2019

@Tratcher

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

@ryanbrandenburg @rynowak @glennc if dotnet new -i doesn't work for VS then how do we verify vs-2017.3.host.json?

@Tratcher

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

I was able to get VS to detect locally built templates by pasting Microsoft.DotNet.Web.ProjectTemplates.3.0.3.0.0-preview-t000.nupkg into D:\github\AspNetCore\.dotnet\x64\sdk\3.0.100-preview-009750\Templates and deleting the prior version. @glennc new the worker template does not show up in the oneaspnet dialog when I do this. Is it filtered by classification?

Tratcher added some commits Feb 11, 2019

Show resolved Hide resolved ...eb.ProjectTemplates/content/Worker-CSharp/.template.config/template.json Outdated
Show resolved Hide resolved ...jectTemplates/content/Worker-CSharp/.template.config/vs-2017.3.host.json Outdated
Show resolved Hide resolved ...jectTemplates/content/Worker-CSharp/.template.config/vs-2017.3.host.json Outdated
"learnMoreLink": "https://go.microsoft.com/fwlink/?LinkID=784883",
"uiFilters": [ "oneaspnet" ],
"supportsDocker": true,
"legacyTemplateIdentity": "Microsoft.NetCore.CSharp.EmptyWorker",

This comment has been minimized.

Copy link
@glennc

glennc Feb 11, 2019

Member

All this auth and port stuff is presumably not required.

This comment has been minimized.

Copy link
@Tratcher

Tratcher Feb 11, 2019

Author Member

I'm not messing with the VS template until we can test it in VS. This is a copy of Empty.

@Tratcher

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

Updated. Anybody else?

@davidfowl
Copy link
Member

left a comment

LGTM. Now we need to try it out once it goes in. I hope we don't generate IIS launch settings for this...

Addressed

@davidfowl

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

SHIPIT!

@Tratcher Tratcher merged commit 597c843 into master Feb 11, 2019

17 of 18 checks passed

AspNetCore-helix-test Build #20190211.28 has failed
Details
AspNetCore-ci Build #20190211.32 succeeded
Details
AspNetCore-ci (Build: Linux ARM) Build: Linux ARM succeeded
Details
AspNetCore-ci (Build: Linux ARM64) Build: Linux ARM64 succeeded
Details
AspNetCore-ci (Build: Linux Musl x64) Build: Linux Musl x64 succeeded
Details
AspNetCore-ci (Build: Linux x64) Build: Linux x64 succeeded
Details
AspNetCore-ci (Build: Windows ARM) Build: Windows ARM succeeded
Details
AspNetCore-ci (Build: Windows x64/x86) Build: Windows x64/x86 succeeded
Details
AspNetCore-ci (Build: macOS) Build: macOS succeeded
Details
AspNetCore-ci (Code check) Code check succeeded
Details
AspNetCore-ci (Test: ANCM IIS) Test: ANCM IIS succeeded
Details
AspNetCore-ci (Test: ANCM IISBackCompat) Test: ANCM IISBackCompat succeeded
Details
AspNetCore-ci (Test: ANCM IISExpress) Test: ANCM IISExpress succeeded
Details
AspNetCore-ci (Test: ANCM IISForwardCompat) Test: ANCM IISForwardCompat succeeded
Details
AspNetCore-ci (Test: Ubuntu 16.04 x64) Test: Ubuntu 16.04 x64 succeeded
Details
AspNetCore-ci (Test: Windows Server 2016 x64) Test: Windows Server 2016 x64 succeeded
Details
AspNetCore-ci (Test: macOS 10.13) Test: macOS 10.13 succeeded
Details
license/cla All CLA requirements met.
Details

@Tratcher Tratcher deleted the tratcher/workertemplate branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.