Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
HeaderPropagation: propagate incoming request headers to outgoing HTTP requests #7921
This PR introduces a
Main feedback on the original PR
@natemcmaster : it can't be added to https://github.com/aspnet/Extensions as it introduce a circulr dependency
I believe it is a common use case which deserves to be included in the
The tests should clarify the behaviour if needed.
It definitely needs some polishing on the definition of the configuration as well as probably removing some of the different behaviours, however I believe opening a PR is the best way to move forward the discussion and shape the behaviour.
I really appreciate you taking the time to review this PR.
changed the title
HeaderPropagation: propagate incoming request headers to outgoing Http requests
Feb 25, 2019
I've introduced the Middleware to solve the concurrency issue.
I'm not convinced about the configuration... the behavior it's probably not really straightforward and can be simplified.
Hi @rynowak , thank you for the review and apologies for the delay on my side :)
I'll have a look tomorrow at why it's not passing on the CI
ci tests on windows are failing, but it looks unrelated
Mar 29, 2019
14 checks passed
@alefranz - we don't backport features to already shipped releases.
If you want a version of this you can use with 2.2, I would suggest grabbing the code and building it from source - it should be straightforward since this package doesn't have tendrils anywhere else.. @Eilon will correct me if I'm wrong but our license allows you to copy as much code as you want (with attribution).