Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed System.Web.Mvc.Test back up #125

Closed
dougbu opened this issue Feb 2, 2018 · 5 comments
Closed

Speed System.Web.Mvc.Test back up #125

dougbu opened this issue Feb 2, 2018 · 5 comments
Assignees
Labels
1 - Ready cost: S Will take up to 2 days to complete task
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Feb 2, 2018

Local builds often look like they're hung for an extended period. When run with /p:BuildInParallel=false or /p:TestInParallel=false, see output similar to the following

  xUnit.net MSBuild Runner (32-bit Desktop .NET 4.0.30319.42000)
    Discovering: System.Web.Mvc.Test
    Discovered:  System.Web.Mvc.Test
    Starting:    System.Web.Mvc.Test
    Finished:    System.Web.Mvc.Test
  === TEST EXECUTION SUMMARY ===
     System.Web.Mvc.Test  Total: 5496, Errors: 0, Failed: 0, Skipped: 0, Time: 3958.681s

Those 66 minutes to execute tests in that assembly are way long. Most assemblies test in less than a minute. Just run other runs for longer than 5 minutes.

Similar long builds are not visible on the CI, tending to build in about 20 minutes. However AppVeyor build duration varies widely from ~25 minutes to ~55 minutes. Builds prior to 5403af6 tended to build in ~8 minutes. That commit added a large number of tests and affected only System.Net.Http.Formatting.Test.

Likely this slowness and variability (not all builds are this slow) relates to system changes and not our code changes. AppVeyor and local dev machines are kept more up-to-date than our CI agents. Then, again, the problem might relate to #95 or system-specific interactions with the recently-upgraded test dependencies (also done last October / November).

@dougbu dougbu added the task label Feb 2, 2018
@mkArtakMSFT
Copy link
Member

@dougbu, so are you certain these are related to the environment changes? How long do the local runs take?

@mkArtakMSFT mkArtakMSFT added this to the 3.2.6 milestone Feb 5, 2018
@mkArtakMSFT
Copy link
Member

Low priority, let's fix when we'll get a chance.

@dougbu
Copy link
Member Author

dougbu commented Feb 5, 2018

so are you certain these are related to the environment changes?

No, only speculating at this point.

How long do the local runs take?

As shown in the original post, just testing the one project can take more than an hour. Local builds taking 45 minutes are common and that greatly reduces productivity in this repo.

@dougbu dougbu modified the milestone: 3.2.6 Mar 6, 2018
@dougbu dougbu removed their assignment Mar 6, 2018
@dougbu dougbu modified the milestones: 3.2.6, 3.2.5-preview2 Mar 13, 2018
@dougbu dougbu self-assigned this Apr 10, 2018
@dougbu
Copy link
Member Author

dougbu commented Apr 10, 2018

Self-assigning since we want this soon-ish.

@dougbu dougbu added the cost: S Will take up to 2 days to complete label Apr 10, 2018
@danroth27 danroth27 modified the milestones: 3.2.5, 3.2.6 Apr 29, 2018
@dougbu dougbu modified the milestones: 3.2.6, 3.2.7 May 11, 2018
@dougbu dougbu modified the milestones: 3.2.7, 3.2.8 Nov 6, 2018
@mkArtakMSFT
Copy link
Member

Closing as we don't plan to do this given it's a low priority work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Ready cost: S Will take up to 2 days to complete task
Projects
None yet
Development

No branches or pull requests

3 participants