Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to preview 4 #1927

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Nov 4, 2019

@JunTaoLuo JunTaoLuo requested review from Pilchie, danroth27 and dougbu Nov 4, 2019
@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

JunTaoLuo commented Nov 4, 2019

@dougbu I'm curious why there's no DotNetFinalVersionKind specified in this repo. Without this, the final build will be 3.1.0 without any pre-release labels I believe.

@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

JunTaoLuo commented Nov 4, 2019

Ah nevermind, we just never set that value, so we always use the pre-release lable. No further changes needed then.

Copy link
Member

dougbu left a comment

Blocking this change until preview3 has gone out

@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

JunTaoLuo commented Nov 8, 2019

FYI @wtgodbe for branding update post preview3

@wtgodbe wtgodbe added the tell-mode label Nov 8, 2019
@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

JunTaoLuo commented Nov 11, 2019

@wtgodbe are these ready to go in yet?

@wtgodbe

This comment has been minimized.

Copy link
Contributor

wtgodbe commented Nov 11, 2019

@JunTaoLuo I was planning on merging these with the stabilization PRs, which I'll merge after dependency flow hits each respective repo (stabilization PRs should be the last thing merged into each repo)

@wtgodbe wtgodbe merged commit c8cc48b into release/3.1 Nov 12, 2019
2 checks passed
2 checks passed
Blazor-ci Build #20191104.3 succeeded with issues
Details
license/cla All CLA requirements met.
@wtgodbe wtgodbe deleted the johluo/update-branding branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.