Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Arcade model for PackageIcon #1935

Merged
merged 4 commits into from Nov 21, 2019

Conversation

@wtgodbe
Copy link
Contributor

wtgodbe commented Nov 14, 2019

Replaces #1930, and updates Arcade. Merge for 3.0.2.

CC @dougbu

@wtgodbe wtgodbe added this to the 3.0.2 milestone Nov 14, 2019
@wtgodbe wtgodbe requested a review from aspnet/build Nov 14, 2019
@dougbu
dougbu approved these changes Nov 14, 2019
@dougbu

This comment has been minimized.

Copy link
Member

dougbu commented Nov 21, 2019

@wtgodbe the conflicts in your various "Arcade model" PRs are happening because @mmitche triggered the Arcade subscriptions everywhere. This just happens to be the first repo where the dependency update PR was merged -- expect more.

So, conflicts should be resolved toward what's in 'release/3.0' branches once those PRs get in. (I'm actually a bit surprised Arcade updates are succeeding w/o your changes though Blazor is a pretty simple repo.)

@wtgodbe wtgodbe merged commit f162981 into release/3.0 Nov 21, 2019
2 checks passed
2 checks passed
Blazor-ci #20191121.1 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@wtgodbe wtgodbe deleted the 30IconArcade branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.