Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building `blazor-wasm` branch #1937

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Nov 18, 2019

Making sure the blazor-wasm branches are being built.

Making sure the blazor-wasm branches are being built.
@mkArtakMSFT mkArtakMSFT requested review from pranavkm and aspnet/build Nov 18, 2019
@dougbu

This comment has been minimized.

Copy link
Member

dougbu commented Nov 18, 2019

Why not rename the branch? blazor-wasm is one we'll be releasing from, correct?

@mkArtakMSFT

This comment has been minimized.

Copy link
Member Author

mkArtakMSFT commented Nov 18, 2019

Why not rename the branch? blazor-wasm is one we'll be releasing from, correct?

We've already included this name in multiple communications / documents, and don't want to start changing stuff as that way we may miss something somewhere.

@dougbu

This comment has been minimized.

Copy link
Member

dougbu commented Nov 18, 2019

We've already included this name in multiple communications / documents, and don't want to start changing stuff as that way we may miss something somewhere.

Alright. Given that, should the blazor-wasm branches have branch protection rules at least similar to those we have for master in the relevant repos?

@dougbu
dougbu approved these changes Nov 18, 2019
@mkArtakMSFT mkArtakMSFT merged commit fc08331 into blazor-wasm Nov 18, 2019
2 checks passed
2 checks passed
Blazor-ci Build #20191118.3 succeeded with issues
Details
license/cla All CLA requirements met.
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/buildBlazorWASM branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.