Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop wiping System.Net.Http #1938

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Nov 20, 2019

This used to be necessary to avoid pulling in 500KB of code that wouldn't work anyway.

However now Mono's BCL has a native WebAssembly-compatible implementation of HttpClient, HttpMessageHandler, etc., we no longer need to strip this out. And in fact we need to stop stripping it out, as it's breaking scenarios like:

var handler = new HttpClientHandler();
var httpClient = new HttpClient(handler);
httpClient.GetJsonAsync(...);
…the right bits for WebAssembly here. Fixes use of "new HttpClientHandler()".
@SteveSandersonMS SteveSandersonMS requested review from pranavkm and javiercn Nov 20, 2019
@SteveSandersonMS SteveSandersonMS changed the base branch from master to blazor-wasm Nov 20, 2019
@SteveSandersonMS SteveSandersonMS merged commit 23759b9 into blazor-wasm Nov 20, 2019
2 checks passed
2 checks passed
Blazor-ci Build #20191120.2 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@SteveSandersonMS SteveSandersonMS deleted the stevesa/stop-wiping-system-net-http branch Nov 20, 2019
@SteveSandersonMS

This comment has been minimized.

Copy link
Member Author

SteveSandersonMS commented Nov 20, 2019

@danroth27 I know some people were saying our HttpClientHandler stuff still isn't working despite our move to the Mono built-in bindings. The change here fixes the last remaining issue I know about currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.