Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ship blazor packages from release/3.1 #1944

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@wtgodbe
Copy link
Contributor

wtgodbe commented Nov 22, 2019

Copy link
Member

javiercn left a comment

LGTM

@javiercn

This comment has been minimized.

Copy link
Member

javiercn commented Nov 25, 2019

@wtgodbe Just to confirm, we already removed the artifacts from 3.1 GA, didn't we?

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 25, 2019

Just to confirm, we already removed the artifacts from 3.1 GA, didn't we?

It looks like we still have Microsoft.AspNetCore.Blazor.Mono.3.1.0-preview4.19562.1 in the drop - should it be removed?

@danroth27

This comment has been minimized.

Copy link
Member

danroth27 commented Nov 25, 2019

It looks like we still have Microsoft.AspNetCore.Blazor.Mono.3.1.0-preview4.19562.1 in the drop - should it be removed?

Yes.

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 25, 2019

There's a number of other preview4 Blazor packages ready to ship with GA, such as Microsoft.AspNetCore.Blazor.3.1.0-preview4.19566.1 from AspNetCore. Should those be removed as well?

Also Mono.WebAssembly.Interop.3.1.0-preview4.19565.4 from Extensions

@danroth27

This comment has been minimized.

Copy link
Member

danroth27 commented Nov 25, 2019

@wtgodbe Yup, pretty much anything with "Blazor", "Blazor.Mono", or "Mono.WebAssembly" in its name should not ship as part of the GA release. Instead we will be shipping those packages separately.

@danroth27

This comment has been minimized.

Copy link
Member

danroth27 commented Nov 25, 2019

@wtgodbe Also Microsoft.JSInterop.

Whoops! Microsoft.JSInterop is used by Blazor Server, so it does need to ship. My bad!

@wtgodbe

This comment has been minimized.

Copy link
Contributor Author

wtgodbe commented Nov 25, 2019

Done

@wtgodbe wtgodbe merged commit f6cb2cb into release/3.1 Nov 25, 2019
2 checks passed
2 checks passed
Blazor-ci #20191122.7 succeeded with issues
Details
license/cla All CLA requirements met.
@wtgodbe wtgodbe deleted the StopShipping branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.