This repository has been archived by the owner. It is now read-only.

Environment source won't work in Linux #227

Closed
jdcrutchley opened this Issue Jun 19, 2015 · 7 comments

Comments

Projects
None yet
9 participants
@jdcrutchley
Copy link

jdcrutchley commented Jun 19, 2015

Linux environments don't allow colon characters in environment variable keys.

@davidfowl

This comment has been minimized.

Copy link
Member

davidfowl commented Jun 19, 2015

Yes this hit me as well. We need an alternative way to access the hierarchy of keys

@muratg

This comment has been minimized.

Copy link
Member

muratg commented Jun 19, 2015

Ugh, this sucks. Apparently . is also not allowed. _ is allowed, but then that might clash with the variable names themselves.

@MichaCo

This comment has been minimized.

Copy link
Contributor

MichaCo commented Jun 20, 2015

If you guys want to be strict _ is most likely the only option, at least according to this open group spec.

$ works too, it seems. Would just be a little bit odd to have $ in the variable name ~$ echo $x$y

I'd vote for _

@natemcmaster

This comment has been minimized.

Copy link
Member

natemcmaster commented Jul 23, 2015

+1 for _

@muratg yes, _ could clash with the variable names themselves. Possible solution: double underscore?

@divega divega added this to the 1.0.0-beta7 milestone Jul 23, 2015

@anurse

This comment has been minimized.

Copy link
Member

anurse commented Aug 3, 2015

@BrennanConroy Let's close on the design of this at the next design meeting.

@glennc

This comment has been minimized.

Copy link
Member

glennc commented Aug 5, 2015

__ because we use _ a lot in other parts of our stack so we cannot use a single underscore without conflicting with those other things.

Apps will still use : when reading keys, but the environment variable config source will change __ into :. So it is transparent to the application author.

@BrennanConroy

This comment has been minimized.

Copy link
Member

BrennanConroy commented Aug 14, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.