This repository has been archived by the owner. It is now read-only.

Ability to strong-name assemblies #963

Closed
bricelam opened this Issue Dec 4, 2014 · 9 comments

Comments

Projects
None yet
6 participants
@bricelam
Member

bricelam commented Dec 4, 2014

kpm buid should allow the assemblies to be strong-named at least for non-ASP.NET frameworks if nothing else.

@bricelam bricelam added the enhancement label Dec 4, 2014

@davidfowl

This comment has been minimized.

Show comment
Hide comment
@davidfowl

davidfowl Dec 4, 2014

Member

No 😃. I think you should use a csproj for this l. Combined with kpm wrap to bootstrap the package building process

Member

davidfowl commented Dec 4, 2014

No 😃. I think you should use a csproj for this l. Combined with kpm wrap to bootstrap the package building process

@rowanmiller

This comment has been minimized.

Show comment
Hide comment
@rowanmiller

rowanmiller Dec 5, 2014

Member

@davidfowl How are we planning to do this for the shared dependencies we have (DI, Logging, etc.)? I realize they won't be strong named on the aspnet50 and aspnetcore50 platforms but the net45 versions will need to be so that EF (and other strong named things) can depend on them.

Member

rowanmiller commented Dec 5, 2014

@davidfowl How are we planning to do this for the shared dependencies we have (DI, Logging, etc.)? I realize they won't be strong named on the aspnet50 and aspnetcore50 platforms but the net45 versions will need to be so that EF (and other strong named things) can depend on them.

@Eilon Eilon reopened this Feb 18, 2015

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Feb 18, 2015

Member

@glennc @davidfowl @bricelam @muratg @lodejard re-opening this based on our recent discussions.

Member

Eilon commented Feb 18, 2015

@glennc @davidfowl @bricelam @muratg @lodejard re-opening this based on our recent discussions.

@muratg muratg added this to the 1.0.0-rc1 milestone Feb 18, 2015

@muratg

This comment has been minimized.

Show comment
Hide comment
@muratg

muratg Feb 18, 2015

Member

👍

Member

muratg commented Feb 18, 2015

👍

@davidfowl davidfowl added the 1 - Ready label Mar 1, 2015

@davidfowl

This comment has been minimized.

Show comment
Hide comment
@davidfowl

davidfowl Mar 6, 2015

Member

We can do this now everywhere thanks to dotnet/roslyn@f591db0

Member

davidfowl commented Mar 6, 2015

We can do this now everywhere thanks to dotnet/roslyn@f591db0

@muratg

This comment has been minimized.

Show comment
Hide comment
@muratg

muratg Mar 6, 2015

Member

YAY!

Member

muratg commented Mar 6, 2015

YAY!

davidfowl added a commit that referenced this issue Mar 6, 2015

Strong name all the things!
- Strong name everything by default because why not
- Automatically rewrite InternalsVisibleTo attributes

#963

@muratg muratg modified the milestones: 1.0.0-beta5, 1.0.0-beta4 Mar 19, 2015

@muratg

This comment has been minimized.

Show comment
Hide comment
@muratg

muratg May 18, 2015

Member

@davidfowl still Beta5?

Member

muratg commented May 18, 2015

@davidfowl still Beta5?

@davidfowl davidfowl modified the milestones: 1.0.0-beta5, 1.0.0-beta6 May 20, 2015

@bricelam

This comment has been minimized.

Show comment
Hide comment
@bricelam

bricelam Jun 8, 2015

Member

As far as the original report is concerned, this is resolved by #2004

Member

bricelam commented Jun 8, 2015

As far as the original report is concerned, this is resolved by #2004

@muratg

This comment has been minimized.

Show comment
Hide comment
@muratg

muratg Jun 9, 2015

Member

Yup, @moozzyk essentially took over this while he's working on servicing.

Member

muratg commented Jun 9, 2015

Yup, @moozzyk essentially took over this while he's working on servicing.

@muratg muratg modified the milestones: 1.0.0-beta5, 1.0.0-beta6 Jun 9, 2015

@muratg muratg assigned moozzyk and unassigned davidfowl Jun 9, 2015

@muratg muratg added 3 - Done and removed 1 - Ready labels Jun 9, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.