New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way to enable Server GC in RC2? #1237

Closed
jeremymeng opened this Issue May 17, 2016 · 9 comments

Comments

Projects
None yet
6 participants
@jeremymeng

The migration guide suggests something like the following, which seems from aspnet/Announcements#175

{
  "runtimeOptions": {
    "gcServer": true,
    "gcConcurrent": true
  }
}

However, when I tried on RC2, it doesn't work for me. I had to use the code below

  "runtimeOptions": {
    "configProperties": {
      "System.GC.Server": true
    }
  }
@danroth27

This comment has been minimized.

Show comment
Hide comment
@danroth27

danroth27 May 18, 2016

Member

@ajaybhargavb @piotrpMSFT

Here is what I see in our RC2 templates:

  "runtimeOptions": {
    "gcServer": true
  }

When you say that the above doesn't work for you can you clarify what exactly you are seeing? How are you detecting whether server GC is being used?

Member

danroth27 commented May 18, 2016

@ajaybhargavb @piotrpMSFT

Here is what I see in our RC2 templates:

  "runtimeOptions": {
    "gcServer": true
  }

When you say that the above doesn't work for you can you clarify what exactly you are seeing? How are you detecting whether server GC is being used?

@jeremymeng

This comment has been minimized.

Show comment
Hide comment
@jeremymeng

jeremymeng May 18, 2016

I have this code:

            if (GCSettings.IsServerGC)
            {
                Console.WriteLine("Server GC");
            }
            else
            {
                Console.WriteLine("Workstation GC");
            }

It prints out "Workstation GC" when I use gcServer": true

I have this code:

            if (GCSettings.IsServerGC)
            {
                Console.WriteLine("Server GC");
            }
            else
            {
                Console.WriteLine("Workstation GC");
            }

It prints out "Workstation GC" when I use gcServer": true

@jeremymeng

This comment has been minimized.

Show comment
Hide comment

A related issue: dotnet/cli#2121
A related commit: aspnet/Benchmarks@b763266

@ajaybhargavb

This comment has been minimized.

Show comment
Hide comment
@ajaybhargavb

ajaybhargavb May 18, 2016

Member

@danroth27, I think the structure of runtimeOptions has changed since the announcement. aspnet/Home#1418 (comment)

Member

ajaybhargavb commented May 18, 2016

@danroth27, I think the structure of runtimeOptions has changed since the announcement. aspnet/Home#1418 (comment)

@danroth27

This comment has been minimized.

Show comment
Hide comment
@danroth27

danroth27 May 19, 2016

Member

@sayedihashimi @phenning @ajaybhargavb @piotrpMSFT @rachelappel So what we have in the templates for RC2 is incorrect? The JSON schema also appears to be incorrect:

image

Member

danroth27 commented May 19, 2016

@sayedihashimi @phenning @ajaybhargavb @piotrpMSFT @rachelappel So what we have in the templates for RC2 is incorrect? The JSON schema also appears to be incorrect:

image

@sayedihashimi

This comment has been minimized.

Show comment
Hide comment
@sayedihashimi

sayedihashimi May 19, 2016

Contributor

The runtime team owns the schema, and I think it can be updated on the fly.

Contributor

sayedihashimi commented May 19, 2016

The runtime team owns the schema, and I think it can be updated on the fly.

@danroth27 danroth27 added the P0 label May 19, 2016

@danroth27

This comment has been minimized.

Show comment
Hide comment
@danroth27

danroth27 May 19, 2016

Member

@sayedihashimi @barrytang This is more than just a schema issue. It looks like what we have in our template project.json files is wrong.

Member

danroth27 commented May 19, 2016

@sayedihashimi @barrytang This is more than just a schema issue. It looks like what we have in our template project.json files is wrong.

@bragma

This comment has been minimized.

Show comment
Hide comment
@bragma

bragma May 24, 2016

I'm a bit lost. Is this valid also for webjobs (console apps) targeting net461?

bragma commented May 24, 2016

I'm a bit lost. Is this valid also for webjobs (console apps) targeting net461?

@danroth27

This comment has been minimized.

Show comment
Hide comment
@danroth27

danroth27 May 24, 2016

Member

No, for console apps target the full .NET Framework you would need to enable server GC in app.config.

Member

danroth27 commented May 24, 2016

No, for console apps target the full .NET Framework you would need to enable server GC in app.config.

@danroth27 danroth27 added 3 - Done and removed 1 - Ready labels Jun 6, 2016

@danroth27 danroth27 closed this Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment