Show how to bind options to a specific config section #1613

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

diddledan commented Jul 5, 2016

Code builds successfully using dotnet.exe command line utility.

Show how to bind options to a specific config section
- fixes issue #867.
- Based on suggested code from @danroth27.

dnfclas commented Jul 5, 2016

Hi @diddledan, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas dnfclas added the cla-required label Jul 5, 2016

dnfclas commented Jul 5, 2016

@diddledan, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added cla-signed and removed cla-required labels Jul 5, 2016

Contributor

Rick-Anderson commented Jul 6, 2016

@divega please review

Owner

divega commented Jul 6, 2016

Please have @HaoK review instead.

Member

HaoK commented Jul 6, 2016

Looks fine, maybe we should consider updating the parent options to also have a MySubOptions property, to demonstrate that nested complex options bind recursively.

Contributor

Rick-Anderson commented Jul 6, 2016

Updated #829 with consider updating the parent options to also have a MySubOptions property, to demonstrate that nested complex options bind recursively.

@rachelappel please resolve merge conflict and merge.

Member

rachelappel commented Jul 7, 2016

Merged b1faeda

@rachelappel rachelappel closed this Jul 7, 2016

ZekeLu added a commit to ZekeLu/Docs that referenced this pull request Jul 8, 2016

fix the un-fixed merge conflit
The merge conflit is not fixed when merging the PR #1613

ZekeLu added a commit to ZekeLu/Docs that referenced this pull request Jul 8, 2016

fix the un-fixed merge conflict
The merge conflict is not fixed when merging the PR #1613

Rick-Anderson added a commit that referenced this pull request Jul 8, 2016

fix the un-fixed merge conflict (#1641)
The merge conflict is not fixed when merging the PR #1613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment