Update source.extension.vsixmanifest #27

Merged
merged 2 commits into from Oct 24, 2016

Projects

None yet

6 participants

@julielerman
Contributor

added visual studio version14 to the power tools vsixmanifest so this will be discoverable from Visual Studio 2015

@julielerman julielerman Update source.extension.vsixmanifest
added visual studio version14 to the power tools vsixmanifest so this will be discoverable from Visual Studio 2015
9c8d456
@dnfclas
dnfclas commented Jul 31, 2016

Hi @julielerman, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@AlbertoMonteiro AlbertoMonteiro commented on an outdated diff Aug 2, 2016
src/PowerTools/source.extension.vsixmanifest
@@ -31,6 +31,9 @@ When right-clicking on a file containing a derived DbContext class, the followin
<VisualStudio Version="12.0">
<Edition>Pro</Edition>
</VisualStudio>
+ <VisualStudio Version="14.0">
+35 <Edition>Pro</Edition>
@AlbertoMonteiro AlbertoMonteiro and 2 others commented on an outdated diff Aug 2, 2016
src/PowerTools/source.extension.vsixmanifest
@@ -31,6 +31,9 @@ When right-clicking on a file containing a derived DbContext class, the followin
<VisualStudio Version="12.0">
<Edition>Pro</Edition>
</VisualStudio>
+ <VisualStudio Version="14.0">
+35 <Edition>Pro</Edition>
+36 </VisualStudio>
@ErikEJ
ErikEJ Aug 2, 2016

Use spaces, not tabs

@julielerman
julielerman Aug 2, 2016 Contributor

what the...? I didn't realize those got in there. Must have come over when I copied from the PR I originally submitted to codeplex. Thanks!

@bricelam bricelam self-assigned this Aug 8, 2016
@ErikEJ
ErikEJ commented Oct 21, 2016

@julielerman Any plans to update this PR?

@julielerman
Contributor

is my edit sufficient? or do I have to start another PR?

@ErikEJ
ErikEJ commented Oct 22, 2016

LGTM - just in time for VS "15" 😄

@bricelam bricelam merged commit b8edeba into aspnet:master Oct 24, 2016
@julielerman
Contributor

@ErikEJ I'm sure there will still be a few people using vs2015. I've had over 60,000 hits to that one blog post. There may be a few more still needing it in the future. ;)
@bricelam thanks! As soon as I see it in the gallery I will update my blog post. Now go back to working on the visualizer for EF Core! :)

@Hotkey
Hotkey commented Nov 28, 2016

We are still waiting for update. When ?

@ErikEJ
ErikEJ commented Nov 28, 2016

@Hotkey In the meantime you can use the download @julielerman prepared in her blog post: http://thedatafarm.com/data-access/installing-ef-power-tools-into-vs2015/

@Hotkey
Hotkey commented Nov 28, 2016

Yes, sorry I'm saw late ;) Thank you @ErikEJ / PowerTools is the real Power ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment