New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow query translator to translate new Guid(x.SomeStringField) #402

Merged
merged 1 commit into from Aug 11, 2018

Conversation

Projects
None yet
3 participants
@leotsarev
Contributor

leotsarev commented Nov 21, 2017

Allow query translator to translate new Guid(x.SomeStringField) to CAST(SomeStringField AS UNIQUEIDENTIFIER)

Fixes #249
@ajcvickers said (in automatic reply, however...) that EF team could accept this kind of community contribution.

  1. Are you actually willing to accept this kind of change at all?
  2. Let's discuss what other casts could be implemented here.
  3. I found correct place to make this change, haven't I?
@dnfclas

This comment has been minimized.

dnfclas commented Nov 21, 2017

CLA assistant check
All CLA requirements met.

@leotsarev

This comment has been minimized.

Contributor

leotsarev commented Nov 28, 2017

When should I expect some kind of answer? Is My PR waiting for some triage meeting or something?

@ajcvickers

This comment has been minimized.

Member

ajcvickers commented Nov 28, 2017

@leotsarev Honestly, we don't look at EF6 PRs as often as maybe we should because of resourcing issues and because we tend to have he team focus on EF6 periodically rather than constantly jumping between Core and 6. Given that it is now the holiday period and people will be out I don't expect that we will get to EF6 issues until next year at the earliest. We do appreciate the PR and we will get to it, we just have to juggle with the schedules and priorities a bit before we get to it.

@leotsarev

This comment has been minimized.

Contributor

leotsarev commented Nov 29, 2017

Hi @ajcvickers ! It's perfectly fine for me to wait. Thanks for setting my expectations. "It should wait until we have time to return for EF6 from Core" is fine for me,

@leotsarev

This comment has been minimized.

Contributor

leotsarev commented Feb 7, 2018

I'm starting to get sad :-)

@ajcvickers ajcvickers merged commit 7e3e847 into aspnet:master Aug 11, 2018

1 check passed

license/cla All CLA requirements met.
Details

@leotsarev leotsarev deleted the leotsarev:guid-constructor branch Aug 11, 2018

@leotsarev

This comment has been minimized.

Contributor

leotsarev commented Aug 11, 2018

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment