Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Strive for reusing common annotations and metadata APIs #2714

Closed
divega opened this Issue Jul 24, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@divega
Copy link
Member

divega commented Jul 24, 2015

Our reverse engineering pipeline uses an IModel that is not bound to CLR types as a representation at various stages, including the model that is passed to the final code generation stage.

Note that IModels that are not bound to CLR types aren't full fidelity with all the capabilities of EF, e.g. per see #2140 it is not possible to represent unbound navigation properties. However, we should strive to reuse all the capabilities that are first class when we can, e.g. favor general purpose well-known annotations vs. reverse engineering-specific annotations for things like table names and column names, column types, and produce/consume the annotation through the strongly typed APIs we have created for that purpose, etc.

@rowanmiller

This comment has been minimized.

Copy link
Member

rowanmiller commented Sep 17, 2015

@lajones is this done now?

@lajones

This comment has been minimized.

Copy link
Member

lajones commented Sep 17, 2015

There's one more small place where I want to update the code.

@lajones

This comment has been minimized.

Copy link
Member

lajones commented Sep 21, 2015

This is now done with commit 057b8df.

@lajones lajones closed this Sep 21, 2015

@lajones lajones modified the milestones: 7.0.0-beta8, 7.0.0 Sep 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.