Fix non-deterministic CROSS APPLY tests #17379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
changed the title
roji
force-pushed
the
NonDeterminsticTests
branch
from
e187c8f
to
20c29b7
Compare
|
@roji No, preview 9 (and all of 3.0 other than in-memory) is done now unless the issue is high priority enough to go through ask-mode approval with the directors. Fixes for test reliability may still be allowed in 3.0 (i.e. not preview 9). I will follow up on this. |
|
Post-3.0. I wouldn't consider it a test reliability issue as it is not (flaky or making build unstable). For now postgre can disable the test or copy whole body when overriding. |
|
Yep, I agree (although maybe test fixes are OK for 3.0, I don't know how it goes). Tell me if you want me to rebase against master. |
|
Rebased on 3.1 |
smitpatel
approved these changes
Aug 23, 2019
ghost
deleted the
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
City is the same for each customer, so effectively the lateral subquery is doing Take(2) without ordering.
(are we still sending PRs to 3.0-preview9?)