New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localization ConfigurationRequestCultureProvider #101

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
4 participants
@hishamco
Contributor

hishamco commented Feb 24, 2016

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Feb 24, 2016

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Feb 24, 2016

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 3, 2016

Member

This sample looks like it's better served by just a blog post, no? Ultimately there are only 2-3 lines of code that seem especially interesting in this sample.

Member

Eilon commented Mar 3, 2016

This sample looks like it's better served by just a blog post, no? Ultimately there are only 2-3 lines of code that seem especially interesting in this sample.

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Mar 4, 2016

Contributor

I already blogged about it in Code Project as well as in in my website (Arabic Version) which I talked about two way to extend the localization. While we already have an EntityFramework Localization provider, I think it 'll be nice to have another sample to show localization extensibility from different angle 😄

Contributor

hishamco commented Mar 4, 2016

I already blogged about it in Code Project as well as in in my website (Arabic Version) which I talked about two way to extend the localization. While we already have an EntityFramework Localization provider, I think it 'll be nice to have another sample to show localization extensibility from different angle 😄

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 4, 2016

Member

I think this particular sample also isn't showing some best practices. E.g. it's loading, parsing, and reading config on every single request.

Member

Eilon commented Mar 4, 2016

I think this particular sample also isn't showing some best practices. E.g. it's loading, parsing, and reading config on every single request.

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Mar 4, 2016

Contributor

FYI the sample read the config data on each request, so if you trying to change the cultures while the application is running it will reflect on the sample.
What I'm doing here is something like Config.CustomProviders.Web showing how you can use custom provider to read the culture infos from, if you have any improvements that I can made to the sample I will do, but I implement the core things is needed

Contributor

hishamco commented Mar 4, 2016

FYI the sample read the config data on each request, so if you trying to change the cultures while the application is running it will reflect on the sample.
What I'm doing here is something like Config.CustomProviders.Web showing how you can use custom provider to read the culture infos from, if you have any improvements that I can made to the sample I will do, but I implement the core things is needed

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 4, 2016

Member

The config system has built-in support for reloading while the app is running. See the Logging repo for example on how loggers use re-loaded config while the app is running. (Search for the word reload in that repo.)

But aside from that, I feel that this example is really just showing how to implement a fairly simple interface, so I'm not sure I see a lot of value there. Each sample we add includes a maintenance cost so we need to be a bit careful about what we add.

Member

Eilon commented Mar 4, 2016

The config system has built-in support for reloading while the app is running. See the Logging repo for example on how loggers use re-loaded config while the app is running. (Search for the word reload in that repo.)

But aside from that, I feel that this example is really just showing how to implement a fairly simple interface, so I'm not sure I see a lot of value there. Each sample we add includes a maintenance cost so we need to be a bit careful about what we add.

@ryanbrandenburg

This comment has been minimized.

Show comment
Hide comment
@ryanbrandenburg

ryanbrandenburg Mar 4, 2016

Member

I'm with @Eilon on this one, this is a good project to have out there for people to consult, but I don't think it's really core enough to enough people's use cases to include as a sample.

Member

ryanbrandenburg commented Mar 4, 2016

I'm with @Eilon on this one, this is a good project to have out there for people to consult, but I don't think it's really core enough to enough people's use cases to include as a sample.

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Mar 4, 2016

Contributor

Thanks @Eilon, what I have seen here either make this sample rich enough or I will implement another rich sample for example DomainRequestCultureProvider which gets the culture infos from the domain aspnet/Localization#43.

Also there's a humble idea to such provider into LocalizationSample, because it's a rich enough example also the people can find a simple RequestCultureProvider
Your thought @Eilon

Contributor

hishamco commented Mar 4, 2016

Thanks @Eilon, what I have seen here either make this sample rich enough or I will implement another rich sample for example DomainRequestCultureProvider which gets the culture infos from the domain aspnet/Localization#43.

Also there's a humble idea to such provider into LocalizationSample, because it's a rich enough example also the people can find a simple RequestCultureProvider
Your thought @Eilon

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 5, 2016

Member

I'm closing this for now. BTW the goal of Entropy isn't to have every possible sample. They're typically based off of common requests and scenarios. As such, please don't just make this sample richer because that still doesn't necessarily mean it's a good fit for this repo.

Member

Eilon commented Mar 5, 2016

I'm closing this for now. BTW the goal of Entropy isn't to have every possible sample. They're typically based off of common requests and scenarios. As such, please don't just make this sample richer because that still doesn't necessarily mean it's a good fit for this repo.

@Eilon Eilon closed this Mar 5, 2016

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Mar 5, 2016

Contributor

I understand, thanks a lot 😄

Contributor

hishamco commented Mar 5, 2016

I understand, thanks a lot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment