New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EntityFramework Localization Sample #76

Closed
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
6 participants
@hishamco
Contributor

hishamco commented Nov 24, 2015

I see many users asking about localization sources, and how to use other sources such as json, database .. etc instead of resx files. I provide this example to use EntityFramework as source
/cc @davidfowl

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Nov 24, 2015

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Nov 24, 2015

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Nov 27, 2015

Contributor

@Eilon @kirthik can you have a look if you don't mind, because I have seen many devs looking for such PR

Contributor

hishamco commented Nov 27, 2015

@Eilon @kirthik can you have a look if you don't mind, because I have seen many devs looking for such PR

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Nov 28, 2015

Member

Why open the same PR in two repos? This is a dup of aspnet/Localization#149, which is still being evaluated.

Member

Eilon commented Nov 28, 2015

Why open the same PR in two repos? This is a dup of aspnet/Localization#149, which is still being evaluated.

@Eilon Eilon closed this Nov 28, 2015

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Nov 29, 2015

Contributor

I'd like to let you know that I made the PR here after @davidfowl suggestion, and I forget to close the one in the localization repo, so if you think that the localiztion repo is the correct place that's fine

Contributor

hishamco commented Nov 29, 2015

I'd like to let you know that I made the PR here after @davidfowl suggestion, and I forget to close the one in the localization repo, so if you think that the localiztion repo is the correct place that's fine

@davidfowl davidfowl reopened this Nov 29, 2015

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Nov 29, 2015

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Nov 29, 2015

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@davidfowl

This comment has been minimized.

Show comment
Hide comment
@davidfowl

davidfowl Nov 29, 2015

Member

@Eilon we should close the other one.

Member

davidfowl commented Nov 29, 2015

@Eilon we should close the other one.

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Nov 29, 2015

Contributor

I closed the other PR

Contributor

hishamco commented Nov 29, 2015

I closed the other PR

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Nov 30, 2015

Contributor

The PR is updated
thanks @Eilon

Contributor

hishamco commented Nov 30, 2015

The PR is updated
thanks @Eilon

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Nov 30, 2015

Member

@hishamco thanks for the update.

@DamianEdwards care to take a look and review?

Member

Eilon commented Nov 30, 2015

@hishamco thanks for the update.

@DamianEdwards care to take a look and review?

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Dec 7, 2015

Contributor

Any updates regarding this PR?

Contributor

hishamco commented Dec 7, 2015

Any updates regarding this PR?

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Dec 8, 2015

Contributor

@DamianEdwards is this looks good for you?

Contributor

hishamco commented Dec 8, 2015

@DamianEdwards is this looks good for you?

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Dec 10, 2015

Member

@hishamco we're working on some improvements to localization (@DamianEdwards is going to log some bugs soon) so we'll hold off on this PR until those changes go through. There will need to be some small changes to this PR but I don't think any major changes.

Member

Eilon commented Dec 10, 2015

@hishamco we're working on some improvements to localization (@DamianEdwards is going to log some bugs soon) so we'll hold off on this PR until those changes go through. There will need to be some small changes to this PR but I don't think any major changes.

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Dec 10, 2015

Contributor

Thanks for clarifications @Eilon

Contributor

hishamco commented Dec 10, 2015

Thanks for clarifications @Eilon

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Dec 23, 2015

Contributor

The PR has been updated to react to latest changes of localization & hosting APIs

Contributor

hishamco commented Dec 23, 2015

The PR has been updated to react to latest changes of localization & hosting APIs

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Dec 23, 2015

Contributor

@DamianEdwards is this PR fine along side with your last PR #83

Contributor

hishamco commented Dec 23, 2015

@DamianEdwards is this PR fine along side with your last PR #83

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Dec 28, 2015

Contributor

@Eilon any updates regarding this

Contributor

hishamco commented Dec 28, 2015

@Eilon any updates regarding this

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Jan 2, 2016

Member

@hishamco sorry I was on vacation and was then sick.

Can you please squash the commits into one?

I think aside from that this looks :shipit: and I'll let @DamianEdwards merge it in if he doesn't spot anything else.

Member

Eilon commented Jan 2, 2016

@hishamco sorry I was on vacation and was then sick.

Can you please squash the commits into one?

I think aside from that this looks :shipit: and I'll let @DamianEdwards merge it in if he doesn't spot anything else.

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Jan 3, 2016

Contributor

No problem @Eilon I hope you are fine now .. I will squash the commits

Contributor

hishamco commented Jan 3, 2016

No problem @Eilon I hope you are fine now .. I will squash the commits

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Feb 2, 2016

Contributor

@Eilon any updates regarding this PR, because i'm planning to push another localization PR

Contributor

hishamco commented Feb 2, 2016

@Eilon any updates regarding this PR, because i'm planning to push another localization PR

Add EntityFramework Localization Sample
React to new options pattern and hosting API changes

Add UseServer

Remove unneeded settings
@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Feb 2, 2016

Contributor

The PR has been updated and the commits squashed into single one

Contributor

hishamco commented Feb 2, 2016

The PR has been updated and the commits squashed into single one

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Feb 2, 2016

Member

@hishamco thanks!

@ryanbrandenburg another one.

Member

Eilon commented Feb 2, 2016

@hishamco thanks!

@ryanbrandenburg another one.

@ryanbrandenburg

This comment has been minimized.

Show comment
Hide comment
@ryanbrandenburg

ryanbrandenburg Feb 3, 2016

Member

Shouldn't this be under the sample folder?

Member

ryanbrandenburg commented Feb 3, 2016

Shouldn't this be under the sample folder?

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Feb 3, 2016

Contributor

Yep, it should be under sample folder .. but I notice few days back it's outside the samples folder, I will push the change right now

Contributor

hishamco commented Feb 3, 2016

Yep, it should be under sample folder .. but I notice few days back it's outside the samples folder, I will push the change right now

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Feb 3, 2016

Contributor

The PR has been updated
thanks @ryanbrandenburg

Contributor

hishamco commented Feb 3, 2016

The PR has been updated
thanks @ryanbrandenburg

@hishamco hishamco referenced this pull request Feb 3, 2016

Merged

Set the server manually #89

@ryanbrandenburg

This comment has been minimized.

Show comment
Hide comment
@ryanbrandenburg
Member

ryanbrandenburg commented Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment