New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples to beta3 #348

Merged
merged 1 commit into from Mar 12, 2015

Conversation

Projects
None yet
6 participants
@friism

friism commented Mar 2, 2015

I've finally gotten the CLA signed

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 2, 2015

Hi @friism, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

ghost commented Mar 2, 2015

Hi @friism, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-required label Mar 2, 2015

@friism

This comment has been minimized.

Show comment
Hide comment
@friism

friism Mar 2, 2015

@msotclas I've gotten the CLA signed already.

friism commented Mar 2, 2015

@msotclas I've gotten the CLA signed already.

@friism friism referenced this pull request Mar 2, 2015

Merged

Add beta3 #38

@ahmetb

This comment has been minimized.

Show comment
Hide comment
@ahmetb

ahmetb Mar 2, 2015

@friism can you please squash commits into one commit?

@Eilon @suhasj can we review this, blocks docker image release for beta3.

ahmetb commented Mar 2, 2015

@friism can you please squash commits into one commit?

@Eilon @suhasj can we review this, blocks docker image release for beta3.

@friism

This comment has been minimized.

Show comment
Hide comment

friism commented Mar 2, 2015

@ahmetalpbalkan commits squashed

Show outdated Hide outdated samples/ConsoleApp/project.json
@@ -7,7 +7,7 @@
"aspnetcore50": {
"dependencies": {
"System.Console": "4.0.0-beta-*"
}
}
}

This comment has been minimized.

@Eilon

Eilon Mar 3, 2015

Member

Tabs 😦 🐼

@Eilon

Eilon Mar 3, 2015

Member

Tabs 😦 🐼

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 3, 2015

Member

@anurse can you evaluate? I vaguely recall you mentioning in another PR about how we want to flow changes for samples (i.e. through dev or not).

Member

Eilon commented Mar 3, 2015

@anurse can you evaluate? I vaguely recall you mentioning in another PR about how we want to flow changes for samples (i.e. through dev or not).

@friism

This comment has been minimized.

Show comment
Hide comment
@friism

friism Mar 3, 2015

@Eilon tabs removed

friism commented Mar 3, 2015

@Eilon tabs removed

@friism

This comment has been minimized.

Show comment
Hide comment
@friism

friism Mar 3, 2015

@Eilon @anurse I'm unsure if flowing changes through dev branch makes sense for this, since it's not a new feature but a bug-fix.

friism commented Mar 3, 2015

@Eilon @anurse I'm unsure if flowing changes through dev branch makes sense for this, since it's not a new feature but a bug-fix.

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 9, 2015

Member

@anurse can you take a look on Monday?

Member

Eilon commented Mar 9, 2015

@anurse can you take a look on Monday?

@Eilon Eilon self-assigned this Mar 9, 2015

@Eilon Eilon added cla-signed and removed cla-required labels Mar 9, 2015

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 9, 2015

Member

Marking as CLA-ok... I manually checked the database.

Member

Eilon commented Mar 9, 2015

Marking as CLA-ok... I manually checked the database.

@Eilon Eilon assigned anurse and unassigned Eilon Mar 9, 2015

@muratg

This comment has been minimized.

Show comment
Hide comment
@muratg

muratg Mar 9, 2015

Member

Looks good to me. I'll let @anurse put the ship it label and handle the PR.

Member

muratg commented Mar 9, 2015

Looks good to me. I'll let @anurse put the ship it label and handle the PR.

@ahmetb

This comment has been minimized.

Show comment
Hide comment
@ahmetb

ahmetb Mar 12, 2015

@muratg @anurse @Eilon ping. this is blocking Docker image release. aspnet/aspnet-docker#38

ahmetb commented Mar 12, 2015

@muratg @anurse @Eilon ping. this is blocking Docker image release. aspnet/aspnet-docker#38

}
}
"dependencies": {
"System.Console": "4.0.0-beta-*"

This comment has been minimized.

@Praburaj

Praburaj Mar 12, 2015

Contributor

This package version can also be fixed. Version will be 4.0.0-beta-22605

@Praburaj

Praburaj Mar 12, 2015

Contributor

This package version can also be fixed. Version will be 4.0.0-beta-22605

Praburaj added a commit that referenced this pull request Mar 12, 2015

@Praburaj Praburaj merged commit edb8b06 into aspnet:master Mar 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment