New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Platform lightup hook #951

Closed
glennc opened this Issue Feb 28, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@glennc
Member

glennc commented Feb 28, 2017

dotnet/core-setup#1597 allows us to do platform lightup on Azure.

We need to implement a hook that allows a server to inject packages and implement a package for Azure App Service that adds the Azure App Service logger.

This issue is for the hook. The implementation would go in the AzureIntegration repo.

@muratg

This comment has been minimized.

Member

muratg commented Mar 8, 2017

@davidfowl when can I review the code? :)

@davidfowl

This comment has been minimized.

Member

davidfowl commented Mar 8, 2017

I haven't been working on this.

davidfowl added a commit that referenced this issue Mar 11, 2017

Add support for executing IHostingStartup in specified assemblies
- Assemblies that are specified in the "hostingStartupAssemblies" configuration (; delimited)
  setting can specify assemblies that use an assembly level attribute (HostingStartupAttribute)
  to specify a type that implements IHostingStartup. This allows hosting environments to
  extend the IWebHostBuilder with platform specific behavior before the application runs.
- If Startup fails and CaptureStartupErrors is true, we'll show the error in the usual
  Startup page.
- Added tests

#951

davidfowl added a commit that referenced this issue Mar 23, 2017

Add support for executing IHostingStartup in specified assemblies
- Assemblies that are specified in the "hostingStartupAssemblies" configuration (; delimited)
  setting can specify assemblies that use an assembly level attribute (HostingStartupAttribute)
  to specify a type that implements IHostingStartup. This allows hosting environments to
  extend the IWebHostBuilder with platform specific behavior before the application runs.
- If Startup fails and CaptureStartupErrors is true, we'll show the error in the usual
  Startup page.
- Added tests

#951

davidfowl added a commit that referenced this issue Mar 23, 2017

Add support for executing IHostingStartup in specified assemblies (#961)
* Add support for executing IHostingStartup in specified assemblies
- Assemblies that are specified in the "hostingStartupAssemblies" configuration (; delimited)
  setting can specify assemblies that use an assembly level attribute (HostingStartupAttribute)
  to specify a type that implements IHostingStartup. This allows hosting environments to
  extend the IWebHostBuilder with platform specific behavior before the application runs.
- Added tests
- Log errors that occur during load and execution of the IHostingStartup
when capture startup errors is off. This happens on start of the application.
- Added debug logging on startup to print out the hosted startup assemblies hosting
processed

#951
@davidfowl

This comment has been minimized.

Member

davidfowl commented Mar 23, 2017

Follow up items

  • If the application throws and the hosting startup assembly throws the hosting startup errors aren't show in the error page.
  • Review error messages and logged error experiences

/cc @glennc

@davidfowl davidfowl closed this Mar 23, 2017

@davidfowl davidfowl added 3 - Done and removed 2 - Working labels Mar 23, 2017

@Tratcher Tratcher reopened this Mar 23, 2017

@davidfowl

This comment has been minimized.

Member

davidfowl commented Mar 24, 2017

@DamianEdwards and I agreed the exception behavior is correct. I don't think there's anything left to do here but remove the /REVIEW: from the codez

@Tratcher

This comment has been minimized.

Member

Tratcher commented Mar 24, 2017

What was the rational?

@DamianEdwards

This comment has been minimized.

Member

DamianEdwards commented Mar 24, 2017

Startup errors capturing is on by default with IIS integration and thus Azure. If it's on, and a loaded module fails, it's logged and the app runs as normal.

@davidfowl

This comment has been minimized.

Member

davidfowl commented Mar 24, 2017

Am closing this bug (again). We can open new bugs as we find issues with the experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment