From 69866a7ab7f8b5363c235fb6a471f865083f791b Mon Sep 17 00:00:00 2001 From: Cesar Blum Silveira Date: Mon, 10 Jul 2017 16:35:21 -0700 Subject: [PATCH] Fix duplicate test warnings. --- .../UriHelperTests.cs | 1 - .../RequestCookiesCollectionTests.cs | 3 --- .../ResponseCookiesTest.cs | 3 --- .../Base64UrlTextEncoderTests.cs | 1 - .../HeaderUtilitiesTest.cs | 16 +++++++++++++++- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/test/Microsoft.AspNetCore.Http.Extensions.Tests/UriHelperTests.cs b/test/Microsoft.AspNetCore.Http.Extensions.Tests/UriHelperTests.cs index 90cd27a9..a27864c5 100644 --- a/test/Microsoft.AspNetCore.Http.Extensions.Tests/UriHelperTests.cs +++ b/test/Microsoft.AspNetCore.Http.Extensions.Tests/UriHelperTests.cs @@ -83,7 +83,6 @@ public void GetDisplayUrlFromRequest() [InlineData("https://127.0.0.0:80/bar", "https", "127.0.0.0:80", "/bar", "", "")] [InlineData("http://[1080:0:0:0:8:800:200C:417A]/index.html", "http", "[1080:0:0:0:8:800:200C:417A]", "/index.html", "", "")] [InlineData("http://example.com///", "http", "example.com", "///", "", "")] - [InlineData("http://example.com///", "http", "example.com", "///", "", "")] public void FromAbsoluteUriParsingChecks( string uri, string expectedScheme, diff --git a/test/Microsoft.AspNetCore.Http.Tests/RequestCookiesCollectionTests.cs b/test/Microsoft.AspNetCore.Http.Tests/RequestCookiesCollectionTests.cs index 6af99b84..70106df0 100644 --- a/test/Microsoft.AspNetCore.Http.Tests/RequestCookiesCollectionTests.cs +++ b/test/Microsoft.AspNetCore.Http.Tests/RequestCookiesCollectionTests.cs @@ -17,9 +17,6 @@ public static TheoryData UnEscapesKeyValues_Data // key, value, expected return new TheoryData { - { "key=value", "key", "value" }, - { "key%2C=%21value", "key,", "!value" }, - { "ke%23y%2C=val%5Eue", "ke#y,", "val^ue" }, { "key=value", "key", "value" }, { "key%2C=%21value", "key,", "!value" }, { "ke%23y%2C=val%5Eue", "ke#y,", "val^ue" }, diff --git a/test/Microsoft.AspNetCore.Http.Tests/ResponseCookiesTest.cs b/test/Microsoft.AspNetCore.Http.Tests/ResponseCookiesTest.cs index 77c7697c..6e13a72f 100644 --- a/test/Microsoft.AspNetCore.Http.Tests/ResponseCookiesTest.cs +++ b/test/Microsoft.AspNetCore.Http.Tests/ResponseCookiesTest.cs @@ -51,9 +51,6 @@ public static TheoryData EscapesKeyValuesBeforeSettingCookieData // key, value, object pool, expected return new TheoryData { - { "key", "value", "key=value" }, - { "key,", "!value", "key%2C=%21value" }, - { "ke#y,", "val^ue", "ke%23y%2C=val%5Eue" }, { "key", "value", "key=value" }, { "key,", "!value", "key%2C=%21value" }, { "ke#y,", "val^ue", "ke%23y%2C=val%5Eue" }, diff --git a/test/Microsoft.AspNetCore.WebUtilities.Tests/Base64UrlTextEncoderTests.cs b/test/Microsoft.AspNetCore.WebUtilities.Tests/Base64UrlTextEncoderTests.cs index 7a5701cc..b91a8f47 100644 --- a/test/Microsoft.AspNetCore.WebUtilities.Tests/Base64UrlTextEncoderTests.cs +++ b/test/Microsoft.AspNetCore.WebUtilities.Tests/Base64UrlTextEncoderTests.cs @@ -55,7 +55,6 @@ public void EncodeInternal_Replaces_UrlEncodableCharacters(string base64EncodedV [InlineData("a_b_c_d", "a/b/c/d=")] [InlineData("a-b_c", "a+b/c===")] [InlineData("a-b_c-d", "a+b/c+d=")] - [InlineData("a-b_c", "a+b/c===")] [InlineData("abcd", "abcd")] public void DecodeToBase64String_ReturnsValid_Base64String(string text, string expectedValue) { diff --git a/test/Microsoft.Net.Http.Headers.Tests/HeaderUtilitiesTest.cs b/test/Microsoft.Net.Http.Headers.Tests/HeaderUtilitiesTest.cs index 807e17cc..6af446ce 100644 --- a/test/Microsoft.Net.Http.Headers.Tests/HeaderUtilitiesTest.cs +++ b/test/Microsoft.Net.Http.Headers.Tests/HeaderUtilitiesTest.cs @@ -33,12 +33,26 @@ public static TheoryData TestValues foreach (var quoted in new[] { true, false }) { - for (var i = 0; i < 60; i++) + data.Add(now, quoted); + + for (var i = 1; i < 60; i++) { data.Add(now.AddSeconds(i), quoted); data.Add(now.AddMinutes(i), quoted); + } + + for (var i = 1; i < DateTime.DaysInMonth(now.Year, now.Month); i++) + { data.Add(now.AddDays(i), quoted); + } + + for (var i = 1; i < 11; i++) + { data.Add(now.AddMonths(i), quoted); + } + + for (var i = 1; i < 5; i++) + { data.Add(now.AddYears(i), quoted); } }