New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_offline does not work if app_offline.htm is empty #174

Closed
moozzyk opened this Issue May 13, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@moozzyk
Contributor

moozzyk commented May 13, 2016

If you drop/create an empty app_offline.htm the application is not getting stopped and the app_offline.htm is not served.

@muratg muratg added this to the 1.0.1 milestone May 18, 2016

@pan-wang

This comment has been minimized.

Show comment
Hide comment
@pan-wang

pan-wang Jun 21, 2016

Contributor

current code loads the file content into a buffer. if the file size is 0, the load is marked as failed and therefore no process shutdown will be triggered. Will fix it in next release.

Contributor

pan-wang commented Jun 21, 2016

current code loads the file content into a buffer. if the file size is 0, the load is marked as failed and therefore no process shutdown will be triggered. Will fix it in next release.

@Tratcher Tratcher added the bug label Jun 22, 2016

@pan-wang

This comment has been minimized.

Show comment
Hide comment
@pan-wang

pan-wang Jun 28, 2016

Contributor

This was fixed

Contributor

pan-wang commented Jun 28, 2016

This was fixed

@Tratcher Tratcher modified the milestones: 1.0.0, 1.0.1 Jun 28, 2016

@Tratcher Tratcher added the 3 - Done label Jun 28, 2016

@Tratcher Tratcher closed this Jun 28, 2016

jkotalik pushed a commit that referenced this issue Dec 8, 2017

Panwang/inproc (#174)
refactoring the code to support inprocess (step 1) with app_offline and Graceful shutdown support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment