Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the presence of Identity UI more explicit in the starter template or documentation #5837

Closed
enumjorge opened this issue Nov 15, 2018 · 8 comments
Assignees
Labels
area-identity Includes: Identity and providers

Comments

@enumjorge
Copy link

I just started looking into authentication for Razor pages, and I found the experience with the starter template to be very confusing. I saw that there's already a couple of GitHub issues related to this, but I think the experience still needs some work. This post on StackOverflow exemplifies exactly what I went through earlier today. I wanted to share some feedback.

The idea of packaging UI in a library, especially UI as involved as authentication, is intriguing. But it hasn't been done in an ASP.net template before (that I'm aware of), so when you create a starter project and you see register and login forms that appear nowhere in your project files, it's quite disorienting. Like the poster in the StackOverflow question, I searched for that string to find the source, but found nothing. Other pages like the landing page, About, etc. do exist, but the account pages are there as if by magic.

The source of the UI, the AddDefaultIdentity statement in Startup.cs, gives no hints that it comes with UI included. The previous method of including AddDefaultUI in your service configuration at least had UI in the name.

Mentioning the existence of Identity UI in the documentation or somewhere in the template would help. I'm not sure what the main entry point to Razor pages is as far as documentation goes, but I was using this article: Introduction to Identity on ASP.NET Core. That might be a good place for a heads up about this new thing called Identity UI, which is the component that causing those authentication forms to appear. But you may be aware of a better place to put it.

@blankenbush
Copy link
Contributor

See this discussion aspnet/Identity#1825

@blowdart
Copy link
Contributor

@HaoK Can we address this with comments in 3.0?

@blowdart
Copy link
Contributor

@ryanbrandenburg Apparently you are Mr Templates now, so can you add a suitable comment?

@ryanbrandenburg
Copy link
Member

I can certainly see how that might be confusing. I think it's unlikely to get noticed in the documentation. @danroth27 do you think just a comment above AddDefaultIdentity would be sufficient?

Also CC @javiercn who does all the Identity work.

@aspnet-hello aspnet-hello transferred this issue from aspnet/Identity Dec 18, 2018
@aspnet-hello aspnet-hello added area-identity Includes: Identity and providers Blocked! labels Dec 18, 2018
@Eilon Eilon added blocked The work on this issue is blocked due to some dependency and removed Blocked! labels Dec 20, 2018
@danroth27
Copy link
Member

@danroth27 do you think just a comment above AddDefaultIdentity would be sufficient?

I'm fine with that, but it's really @blowdart's call.

@danroth27 danroth27 assigned blowdart and unassigned danroth27 Jan 24, 2019
@blowdart
Copy link
Contributor

I already said a comment would do.

@blowdart blowdart removed their assignment Jan 24, 2019
@blowdart
Copy link
Contributor

Comment should read as

/// .addDefaultUI embeds web pages to support login, logout and other identity functions without having to create pages in your project.
/// For more details see https://docs.microsoft.com/en-us/aspnet/core/security/authentication/identity
/// To create pages and code in your project rather than use the library see https://docs.microsoft.com/en-us/aspnet/core/security/authentication/scaffold-identity

@ryanbrandenburg ryanbrandenburg added 1 - Ready and removed blocked The work on this issue is blocked due to some dependency cost: S labels Jan 24, 2019
@javiercn
Copy link
Member

We can close this now as the default experience for templates already includes .AddIdentityUI with the framework version.

@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-identity Includes: Identity and providers
Projects
None yet
Development

No branches or pull requests

8 participants