New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login doesn't show registered social logins after error #2074

Closed
wpqs opened this Issue Nov 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@wpqs

wpqs commented Nov 19, 2018

I'm using ASPNET Core 2.1 with Razor Pages UI Library and noticed that whilst registered social logins appear when I open the Login page, they disappear after an error like incorrect password.

There seems to be a bug in Identity\Pages\Account\Login.cshtml.cs as

 public IList<AuthenticationScheme> ExternalLogins { get; set; }

is only initialised in OnGetAsync(), but if an error happens OnPostAsync() then Page() is returned so OnGetAsyn() doesn't get called. Changing error handling in OnPostAsync() so RedirectToPage() is returned seems to fix the problem.

Please confirm this is a bug and comment on my fix

@blowdart

This comment has been minimized.

Member

blowdart commented Nov 19, 2018

Dupe of #1636

@blowdart blowdart closed this Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment