Skip to content
This repository has been archived by the owner. It is now read-only.

Upgrade projects to netcoreapp3.0 #2072

Merged
merged 2 commits into from Nov 17, 2018
Merged

Upgrade projects to netcoreapp3.0 #2072

merged 2 commits into from Nov 17, 2018

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Nov 16, 2018

Changes:

  • Upgrade dependencies
  • Change TFM on Microsoft.AspNetCore.Identity to netcoreapp3.0
  • Remove .NET Framework tests

Part of dotnet/aspnetcore#3754

* Upgrade dependencies
* Change TFM on Microsoft.AspNetCore.Identity to netcoreapp3.0
* Remove .NET Framework tests
@natemcmaster natemcmaster requested review from ajcvickers and HaoK Nov 16, 2018
HaoK
HaoK approved these changes Nov 16, 2018
@natemcmaster
Copy link
Contributor Author

@natemcmaster natemcmaster commented Nov 16, 2018

Whoa, lots of test failures. Are these already known issues @HaoK?

@HaoK
Copy link
Member

@HaoK HaoK commented Nov 16, 2018

That looks to be errors from the razor UI stuff, maybe the upgrade to 3.0 broke something there? @javiercn @pranavkm any ideas?

@pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Nov 16, 2018

Can't find'C:\projects\identity\test\Identity.FunctionalTests\bin\Release\netcoreapp3.0\Identity.DefaultUI.WebSite.deps.json'

Does the 3.0 Sdk no longer generate a deps file?

@natemcmaster
Copy link
Contributor Author

@natemcmaster natemcmaster commented Nov 16, 2018

Does the 3.0 Sdk no longer generate a deps file?

This sounds like something @ryanbrandenburg was investigating. Is this the issue you were seeing, Ryan?

@ryanbrandenburg
Copy link
Member

@ryanbrandenburg ryanbrandenburg commented Nov 17, 2018

I don't recall having missing deps.json files.

@natemcmaster
Copy link
Contributor Author

@natemcmaster natemcmaster commented Nov 17, 2018

This might have been it: 43bae5e Tests pass locally now.

@natemcmaster
Copy link
Contributor Author

@natemcmaster natemcmaster commented Nov 17, 2018

Yup, that was me. Mea culpa, missed one line.

@natemcmaster natemcmaster merged commit 68b878f into master Nov 17, 2018
3 checks passed
@natemcmaster natemcmaster deleted the namc/3.0 branch Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants