Skip to content
This repository has been archived by the owner. It is now read-only.

Upgrade projects to netcoreapp3.0 #2072

Merged
merged 2 commits into from Nov 17, 2018

Conversation

@natemcmaster
Copy link
Contributor

natemcmaster commented Nov 16, 2018

Changes:

  • Upgrade dependencies
  • Change TFM on Microsoft.AspNetCore.Identity to netcoreapp3.0
  • Remove .NET Framework tests

Part of aspnet/AspNetCore#3754

Nate McMaster
* Upgrade dependencies
* Change TFM on Microsoft.AspNetCore.Identity to netcoreapp3.0
* Remove .NET Framework tests
@natemcmaster natemcmaster requested review from ajcvickers and HaoK Nov 16, 2018
@HaoK
HaoK approved these changes Nov 16, 2018
@natemcmaster

This comment has been minimized.

Copy link
Contributor Author

natemcmaster commented Nov 16, 2018

Whoa, lots of test failures. Are these already known issues @HaoK?

@HaoK

This comment has been minimized.

Copy link
Member

HaoK commented Nov 16, 2018

That looks to be errors from the razor UI stuff, maybe the upgrade to 3.0 broke something there? @javiercn @pranavkm any ideas?

@pranavkm

This comment has been minimized.

Copy link
Member

pranavkm commented Nov 16, 2018

Can't find'C:\projects\identity\test\Identity.FunctionalTests\bin\Release\netcoreapp3.0\Identity.DefaultUI.WebSite.deps.json'

Does the 3.0 Sdk no longer generate a deps file?

@natemcmaster

This comment has been minimized.

Copy link
Contributor Author

natemcmaster commented Nov 16, 2018

Does the 3.0 Sdk no longer generate a deps file?

This sounds like something @ryanbrandenburg was investigating. Is this the issue you were seeing, Ryan?

@ryanbrandenburg

This comment has been minimized.

Copy link
Member

ryanbrandenburg commented Nov 17, 2018

I don't recall having missing deps.json files.

Nate McMaster
@natemcmaster

This comment has been minimized.

Copy link
Contributor Author

natemcmaster commented Nov 17, 2018

This might have been it: 43bae5e Tests pass locally now.

@natemcmaster

This comment has been minimized.

Copy link
Contributor Author

natemcmaster commented Nov 17, 2018

Yup, that was me. Mea culpa, missed one line.

@natemcmaster natemcmaster merged commit 68b878f into master Nov 17, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@natemcmaster natemcmaster deleted the namc/3.0 branch Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.