This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Don't wait to consume the entire request body for Connection: close requests #406
Comments
Was putting a PR together for this but it needs to go after "Precomputed header bytes" #367 if that's happening as its all change |
@benaadams The fix is simple. I was thinking something like:
Is this what you were thinking? The only reason this isn't in a PR yet is we need a regression test. |
@CesarBS yes, good point :) |
cesarblum
pushed a commit
that referenced
this issue
Nov 20, 2015
cesarblum
pushed a commit
that referenced
this issue
Nov 21, 2015
Closed by e4fd91b. |
This was referenced Jan 22, 2016
@CesarBS Is this related? BrowserSync/browser-sync#905 |
@amcdnl Looks like it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If you hit a sample app running on Kestrel with ab (apache bench which makes HTTP/1.0 requests), every request times out.
This is caused by Kestrel becoming stuck on
await messageBody.Consume()
inFrame.RequestProcessingAsync
.I think we fix this by simply not consuming the rest of the request for non keep-alive connections.
The text was updated successfully, but these errors were encountered: