New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken behavior when dealing with libraries containing an @ symbol #329

Open
nickalbrecht opened this Issue Jul 25, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@nickalbrecht

nickalbrecht commented Jul 25, 2018

Functional impact

Attempting to check for updates to something like SignalR results in breaking the library name

Minimal repro steps

Set your libman.json file as follows

{
  "defaultProvider": "unpkg",
  "libraries": [
    {
      "library": "@aspnet/signalr@1.0.2",
      "files": [
        "dist/browser/signalr.js"
      ],
      "destination": "wwwroot/vendor/signalr"
    }
  ],
  "version": "1.0"
}

Then using the lightbulb quick action to try and check for updates to SignalR.

Expected result

It should determine there are no updates available

Actual result

You'll get the option to update to "Stable: 1.0.2"
Clicking to do so will replace the entire library name from "@aspnet/signalr@1.0.2" to "1.0.2".

Further technical details

I believe It's just parsing off of the first found @ symbol, when it should be using the last one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment