New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Include a jsDelivr provider #344

Open
justcla opened this Issue Aug 8, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@justcla
Contributor

justcla commented Aug 8, 2018

User @Drgy submitted a PR #338 to Add the jsDelivr provider to Library Manager.

Need to determine:
Should Library Manager include jsDelivr as a provider?
If so, should it replace the existing UnPkg provider?

@justcla

This comment has been minimized.

Show comment
Hide comment
@justcla

justcla Aug 8, 2018

Contributor

Question:
What's the main benefit of using jsDelivr over UnPkg?

Contributor

justcla commented Aug 8, 2018

Question:
What's the main benefit of using jsDelivr over UnPkg?

@MartinKolarik

This comment has been minimized.

Show comment
Hide comment
@MartinKolarik

MartinKolarik Aug 8, 2018

Hi @justcla - Martin from jsDelivr here.

I think the most important benefits are:

  • jsDelivr pulls files from both npm and GitHub, allowing you to support both with one provider (all our APIs work exactly the same way for both to make this easy). Support for GitHub was already requested by some users and not available yet.
  • On-demand minification, which allows users to get minified files even if those are not available from the package author.
  • Public API, which allows implementing other interesting features (such as #343).

Related to my last point - we are interesting in providing the best developer experience for devs using VS and jsDelivr and will be happy to help with future maintenance/improvements. @Drgy already mentioned some of those in his PR and I'm sure we'll have other ideas too.

Unpkg also is, quoting from its website, "a free, best-effort service and cannot provide any uptime or support guarantees". We are focused on usage in production systems and try to take things a bit more seriously.

Our main goal was to provide additional features to users of this extension. jsDelivr covers everything provided by unpkg but you could still choose to keep both and let people decide which they use.

MartinKolarik commented Aug 8, 2018

Hi @justcla - Martin from jsDelivr here.

I think the most important benefits are:

  • jsDelivr pulls files from both npm and GitHub, allowing you to support both with one provider (all our APIs work exactly the same way for both to make this easy). Support for GitHub was already requested by some users and not available yet.
  • On-demand minification, which allows users to get minified files even if those are not available from the package author.
  • Public API, which allows implementing other interesting features (such as #343).

Related to my last point - we are interesting in providing the best developer experience for devs using VS and jsDelivr and will be happy to help with future maintenance/improvements. @Drgy already mentioned some of those in his PR and I'm sure we'll have other ideas too.

Unpkg also is, quoting from its website, "a free, best-effort service and cannot provide any uptime or support guarantees". We are focused on usage in production systems and try to take things a bit more seriously.

Our main goal was to provide additional features to users of this extension. jsDelivr covers everything provided by unpkg but you could still choose to keep both and let people decide which they use.

@jodavis jodavis added the discussion label Aug 16, 2018

@Tsabo

This comment has been minimized.

Show comment
Hide comment
@Tsabo

Tsabo Aug 23, 2018

Should it be included, absolutely. Why? Because, any option other than UnPkg is a better option. I spent two hours last night trying to install one package and it still isn't installed. I'm back at it this morning trying it again and watching it fail over and over again. The twenty-five second timeout on UnPkg is dreadful.

image

It would also be nice to be able to have a provider that can pull from our private MyGet NPM/Bower feeds. Another idea would be to have a provider for content only NuGet packages, for example DevExtreme.Web.

Tsabo commented Aug 23, 2018

Should it be included, absolutely. Why? Because, any option other than UnPkg is a better option. I spent two hours last night trying to install one package and it still isn't installed. I'm back at it this morning trying it again and watching it fail over and over again. The twenty-five second timeout on UnPkg is dreadful.

image

It would also be nice to be able to have a provider that can pull from our private MyGet NPM/Bower feeds. Another idea would be to have a provider for content only NuGet packages, for example DevExtreme.Web.

@MartinKolarik

This comment has been minimized.

Show comment
Hide comment
@MartinKolarik

MartinKolarik Aug 23, 2018

Because, any option other than UnPkg is a better option.

And you haven't even seen some of the more funny issues yet 😆

It would also be nice to be able to have a provider that can pull from our private MyGet NPM

We are currently considering adding support for private npm/GitHub packages to jsDelivr.

MartinKolarik commented Aug 23, 2018

Because, any option other than UnPkg is a better option.

And you haven't even seen some of the more funny issues yet 😆

It would also be nice to be able to have a provider that can pull from our private MyGet NPM

We are currently considering adding support for private npm/GitHub packages to jsDelivr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment