DomainRequestCultureProvider #43

Closed
hishamco opened this Issue Jun 26, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@hishamco
Contributor

hishamco commented Jun 26, 2015

It's quite often to detect the localization culture based on domain or sub domain, this provider may support various formats such as:

en.domain.com
domain.com.en
domain.com.au
domain.com/en-au/default.aspx

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Sep 15, 2015

Contributor

@kirthik can I start to make a PR to support DomainRequestCultureProvider?

Contributor

hishamco commented Sep 15, 2015

@kirthik can I start to make a PR to support DomainRequestCultureProvider?

@miloush

This comment has been minimized.

Show comment
Hide comment
@miloush

miloush Nov 2, 2015

Even most of the Microsoft's web sites use path segment for localization and I would expect it to be one of the built-in providers. It is also easier to provide links to specific localizations in that case.

On the other side I don't think the host names - especially the TLD - are good idea, as you would basically need a lookup table for most of them (.at) and there are tricky cases too (.in) ...

miloush commented Nov 2, 2015

Even most of the Microsoft's web sites use path segment for localization and I would expect it to be one of the built-in providers. It is also easier to provide links to specific localizations in that case.

On the other side I don't think the host names - especially the TLD - are good idea, as you would basically need a lookup table for most of them (.at) and there are tricky cases too (.in) ...

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Nov 2, 2015

Contributor

@miloush the basic idea that I mentioned before is all about segements 😄 , regarding the .it, .in .. etc they are parent cultures so no need to lookup table

Contributor

hishamco commented Nov 2, 2015

@miloush the basic idea that I mentioned before is all about segements 😄 , regarding the .it, .in .. etc they are parent cultures so no need to lookup table

@miloush

This comment has been minimized.

Show comment
Hide comment
@miloush

miloush Nov 2, 2015

@hishamco No these are not parent cultures. .it is, but you have en-IN, ta-IN, sa-IN where parent cultures are en, ta resp. sa. The same with China (parent is zh) and Arabic cultures (parent is ar) and pretty much all others where the culture neutral name differs from the culture specifier (.at .nz .cz ...). And don't forget there are cultures that differ by script (like sr-Cyrl-RS vs sr-Latn-RS).

miloush commented Nov 2, 2015

@hishamco No these are not parent cultures. .it is, but you have en-IN, ta-IN, sa-IN where parent cultures are en, ta resp. sa. The same with China (parent is zh) and Arabic cultures (parent is ar) and pretty much all others where the culture neutral name differs from the culture specifier (.at .nz .cz ...). And don't forget there are cultures that differ by script (like sr-Cyrl-RS vs sr-Latn-RS).

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Nov 2, 2015

Contributor

anyway it's in a Backlog, and may it need a good design
thanks @miloush

Contributor

hishamco commented Nov 2, 2015

anyway it's in a Backlog, and may it need a good design
thanks @miloush

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Jan 3, 2017

Member

Closing because we have no plans to ship this.

Member

Eilon commented Jan 3, 2017

Closing because we have no plans to ship this.

@Eilon Eilon closed this Jan 3, 2017

@hishamco

This comment has been minimized.

Show comment
Hide comment
@hishamco

hishamco Jan 4, 2017

Contributor

This could be done easily now after shipping RouteDataRequestCultureProvider as well as middleware as filter 😄

Contributor

hishamco commented Jan 4, 2017

This could be done easily now after shipping RouteDataRequestCultureProvider as well as middleware as filter 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment