This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Add more configuration options for logging, add reload #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rynowak, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| ["Microsoft"] = (LogLevel)(DateTimeOffset.Now.Second % 5 + 1), | ||
| } | ||
| }; | ||
| }); |
There was a problem hiding this comment.
/cc @divega - is this more of what you had in mind?
rynowak
force-pushed
the
config-reader
branch
5 times, most recently
from
efb11a5
to
4968619
Compare
| files.Watch(filename).RegisterChangeCallback(callback, null); | ||
| return config; | ||
| } | ||
| } |
There was a problem hiding this comment.
Ignore this file, I've already opened a PR on configuration.
|
|
rynowak
force-pushed
the
config-reader
branch
from
4968619
to
ec55b54
Compare
rynowak
force-pushed
the
config-reader
branch
from
ec55b54
to
9f38745
Compare
|
Checked in to release and merged to dev. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.