Skip to content
This repository has been archived by the owner. It is now read-only.

Update to newer version of Serilog that supports flushing #499

Merged
merged 1 commit into from Oct 25, 2016

Conversation

Projects
None yet
5 participants
@pakrym
Copy link
Member

pakrym commented Oct 6, 2016

And use it.

Closes: #497

@@ -19,7 +19,7 @@
"NETStandard.Library": "1.6.1-*",
"Serilog.Extensions.Logging": "1.0.0",
"Serilog.Sinks.PeriodicBatching": "2.0.0",
"Serilog.Sinks.RollingFile": "2.1.0",
"Serilog.Sinks.RollingFile": "3.1.0-dev-00745",

This comment has been minimized.

@pranavkm

pranavkm Oct 6, 2016

Member

Can you remove the imports with this change?

@@ -41,7 +41,14 @@ public class AzureAppServicesDiagnosticsSettings
/// </summary>
public string BlobName { get; set; } = "applicationLog.txt";

/// <summary>
/// Gets of sets the maximum size of the background log message queue.

This comment has been minimized.

@ryanbrandenburg

ryanbrandenburg Oct 6, 2016

Member

Gets or sets

public int BackgroundQueueSize { get; set; }

/// <summary>
/// Gets or sets period with which logs would be flushed to disk

This comment has been minimized.

@ryanbrandenburg

ryanbrandenburg Oct 6, 2016

Member

"Gets or sets the period after which logs will be flushed to disk."?

@@ -29,7 +31,8 @@ public class FileLoggerProvider
/// <param name="retainedFileCountLimit">A strictly positive value representing the maximum retained file count</param>
/// <param name="backgroundQueueSize">The maximum size of the background queue</param>
/// <param name="outputTemplate">A message template describing the output messages</param>
public FileLoggerProvider(int fileSizeLimit, int retainedFileCountLimit, int backgroundQueueSize, string outputTemplate)
/// <param name="flushPeriod">A period with which logs would be flushed to disk</param>

This comment has been minimized.

@ryanbrandenburg

ryanbrandenburg Oct 6, 2016

Member

Similar phrasing to above.

@pakrym pakrym force-pushed the pakrym/update-serilog branch from 18e7530 to 7df513c Oct 6, 2016

@nblumhardt

This comment has been minimized.

Copy link
Contributor

nblumhardt commented Oct 10, 2016

Heads-up, Serilog.Sinks.RollingFile 3.1.0 is now final.

@pakrym pakrym force-pushed the pakrym/update-serilog branch from 7df513c to 6615209 Oct 12, 2016

@pakrym pakrym changed the title WIP: Update to newer version of Serilog that supports flushing Update to newer version of Serilog that supports flushing Oct 12, 2016

@pakrym

This comment has been minimized.

Copy link
Member Author

pakrym commented Oct 12, 2016

Updated.

@pakrym pakrym merged commit bff2ae0 into dev Oct 25, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@natemcmaster natemcmaster deleted the pakrym/update-serilog branch Nov 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.